Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: suppress deprecation warning for ADC#1815

Merged
sai-sunder-s merged 3 commits intomainfrom
adcwarning
Sep 30, 2025
Merged

fix: suppress deprecation warning for ADC#1815
sai-sunder-s merged 3 commits intomainfrom
adcwarning

Conversation

@sai-sunder-s
Copy link
Copy Markdown
Contributor

@sai-sunder-s sai-sunder-s commented Sep 30, 2025

ADC still should be allowed to load creds for any cred type. It internally uses the deprecated load_credentials_from_file method and it is ok, so suppressing the warning.
(There is no internal usage for the other deprecated method load_credentials_from_dict.)

Fixes #1814

@sai-sunder-s sai-sunder-s marked this pull request as ready for review September 30, 2025 18:34
@sai-sunder-s sai-sunder-s requested review from a team September 30, 2025 18:34
@sai-sunder-s sai-sunder-s requested a review from a team as a code owner September 30, 2025 18:34
@sai-sunder-s sai-sunder-s added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 30, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 30, 2025
@sai-sunder-s sai-sunder-s merged commit 751ce3f into main Sep 30, 2025
15 checks passed
@sai-sunder-s sai-sunder-s deleted the adcwarning branch September 30, 2025 21:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update a load_credentials_* method into a credential-type-specific load method

3 participants