Skip to content

feat(bigtable): Add support for creating Instance with tags#13459

Merged
bhshkh merged 3 commits intogoogleapis:mainfrom
dohun-dev:add_instance_tags
Feb 25, 2026
Merged

feat(bigtable): Add support for creating Instance with tags#13459
bhshkh merged 3 commits intogoogleapis:mainfrom
dohun-dev:add_instance_tags

Conversation

@dohun-dev
Copy link
Contributor

No description provided.

@dohun-dev dohun-dev requested review from a team December 10, 2025 04:14
@dohun-dev dohun-dev requested a review from a team as a code owner December 10, 2025 04:14
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Dec 10, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @dohun-dev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Bigtable client library by adding support for creating instances with associated tags. It modifies the configuration structures and instance creation methods to include a Tags map, allowing users to specify resource tags. The changes ensure that the client can correctly pass tag information to the Bigtable service, improving resource management and organization capabilities for Bigtable instances.

Highlights

  • New Feature: Instance Tagging: Introduced a new Tags field to the InstanceConf and InstanceWithClustersConfig structs, enabling the association of TagKey and TagValue resource names with Bigtable instances during creation.
  • API Integration: The CreateInstance and CreateInstanceWithClusters methods in bigtable/admin.go have been updated to accept and pass the new Tags field to the underlying Bigtable API.
  • Test Coverage: A new test case, TestInstanceAdmin_CreateInstance_WithTags, has been added to bigtable/admin_test.go to ensure that instances can be created with tags without errors. It notes that direct verification of tag persistence is not possible through instance metadata.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for specifying tags when creating a Bigtable instance. The changes correctly plumb the Tags field through the InstanceConf, InstanceWithClustersConfig, and finally to the API request. A new test is also added to cover this functionality. My review includes one point of feedback on the new test, where the key and value for the tags map appear to be inverted compared to the field's documentation.

@dohun-dev dohun-dev requested review from a team as code owners February 19, 2026 00:58
@bhshkh bhshkh merged commit 1bce843 into googleapis:main Feb 25, 2026
10 of 12 checks passed
bhshkh added a commit that referenced this pull request Mar 16, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.8.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:19bb93e8f1f916c61b597db2bad65dc432f79baaabb210499d7d0e4ad1dffe29
<details><summary>bigtable: 1.43.0</summary>

##
[1.43.0](bigtable/v1.42.0...bigtable/v1.43.0)
(2026-03-16)

### Features

* Add support for creating Instance with tags (#13459)
([1bce843](1bce843e))

* support tiered storage (#13793)
([39a25b9](39a25b92))

* add handling of longupdown metrics aka gauge (#13871)
([519ed9b](519ed9b0))

* Use direct access when supported. Guarded by enabling… (#13873)
([5ea1f5f](5ea1f5f9))

* add preemptive connection recycler (#13860)
([6b69ee3](6b69ee38))

* make downscalling less aggressive (#14123)
([7ac72cc](7ac72cc8))

* add pacemaker in connpool (#13862)
([9af047f](9af047f7))

* populate ip protocol for direct access checker and rename a method to
be concise (#14011)
([9c5e655](9c5e6551))

* add connection factory to abstract connection (#13755)
([b08ea15](b08ea15f))

* make pow of 2 default lb policy (#14131)
([b5f7bf2](b5f7bf27))

* derive conn pool from resolver (#14147)
([b903e29](b903e299))

* add load balancing penalty for channel (#14149)
([bb64998](bb649988))

* cap increase in conn for dynamic chan pool (#14144)
([e0701a4](e0701a46))

* switch to rand v2 (#14008)
([ee6f425](ee6f4251))

### Bug Fixes

* slighly change instruction for direct access (#14119)
([7dd4948](7dd4948d))

* refactor bigtable.go into separate file path per interfaces (#13818)
([c8ae2e2](c8ae2e2a))

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants