fix(auth): add InternalOptions.TelemetryAttributes for internal client use#13641
fix(auth): add InternalOptions.TelemetryAttributes for internal client use#13641quartzmo merged 2 commits intogoogleapis:mainfrom
Conversation
Summary of ChangesHello @quartzmo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the internal client options by adding a mechanism to attach static telemetry attributes to OpenTelemetry signals. This change aims to improve the observability of internal client operations by providing consistent identification across various telemetry data, such as traces and metrics, without affecting external API consumers. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new field TelemetryAttributes to the InternalOptions struct in both grpctransport and httptransport packages. This change allows internal clients to specify telemetry attributes for OpenTelemetry signals. The implementation is straightforward and correct, adding the field and its corresponding documentation. The changes are consistent across both packages and follow Go conventions. I've added a couple of suggestions to improve the documentation for this new field to clarify ownership of the map and prevent potential misuse, given that maps are reference types.
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.8.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:d2dee66d7c8c1d673fac26280164ea24015b79491b7f9d6ba369e6a98ab3420c <details><summary>auth: 0.18.1</summary> ## [0.18.1](auth/v0.18.0...auth/v0.18.1) (2026-01-21) ### Bug Fixes * add InternalOptions.TelemetryAttributes for internal client use (#13641) ([3876978](38769789)) * remove singleton and restore normal usage of otelgrpc.clientHandler (#13522) ([673d4b0](673d4b05)) </details>
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.8.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:d2dee66d7c8c1d673fac26280164ea24015b79491b7f9d6ba369e6a98ab3420c <details><summary>auth: 0.18.1</summary> ## [0.18.1](auth/v0.18.0...auth/v0.18.1) (2026-01-21) ### Bug Fixes * add InternalOptions.TelemetryAttributes for internal client use (#13641) ([3876978](38769789)) * remove singleton and restore normal usage of otelgrpc.clientHandler (#13522) ([673d4b0](673d4b05)) </details>
refs: googleapis/google-api-go-client#3442