fix(auth): remove content-type header from idms get requests#9508
Merged
codyoss merged 2 commits intogoogleapis:mainfrom Mar 12, 2024
Merged
fix(auth): remove content-type header from idms get requests#9508codyoss merged 2 commits intogoogleapis:mainfrom
codyoss merged 2 commits intogoogleapis:mainfrom
Conversation
Detailed description here https://issuetracker.google.com/issues/328089077
Member
|
Hey thanks for the detailed report and PR. I have forwarded the bug to our internal auth team. If this is a change we should make we likely need to make it in all the languages we support. So until they make a decision I will hold off on this PR. |
Contributor
Author
|
Thanks. I already sent a similar PR to the python SDK |
codyoss
added
the
do not merge
|
Hi @codyoss , i made a similar fix in the dependency source which doesn't have this conflict. golang/oauth2#711 |
codyoss
removed
the
do not merge
codyoss
added
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Member
|
@peter-volkov Thank you for raising this to our attention. We will be moving forward with this patch. |
gopherbot
pushed a commit
to golang/oauth2
that referenced
this pull request
Mar 12, 2024
This is a fix on the googleapis/google-cloud-go#9508. The aws provider in that library is a ported dependency from here. Change-Id: I28e1efa4fdb8292210b695a164a55060c83dae88 GitHub-Last-Rev: c425f2d GitHub-Pull-Request: #711 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/570875 Reviewed-by: Cody Oss <codyoss@google.com> Reviewed-by: Chris Smith <chrisdsmith@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Contributor
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge: exact
codyoss
changed the title
codyoss
approved these changes
Mar 12, 2024
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
🤖 I have created a release *beep* *boop* --- ## [0.2.0](https://togithub.com/googleapis/google-cloud-go/compare/auth/v0.1.1...auth/v0.2.0) (2024-04-15) ### Features * **auth/credentials/externalaccount:** Add default TokenURL ([#9700](https://togithub.com/googleapis/google-cloud-go/issues/9700)) ([81830e6](https://togithub.com/googleapis/google-cloud-go/commit/81830e6848ceefd055aa4d08f933d1154455a0f6)) * **auth:** Add downscope.Options.UniverseDomain ([#9634](https://togithub.com/googleapis/google-cloud-go/issues/9634)) ([52cf7d7](https://togithub.com/googleapis/google-cloud-go/commit/52cf7d780853594291c4e34302d618299d1f5a1d)) * **auth:** Add universe domain to grpctransport and httptransport ([#9663](https://togithub.com/googleapis/google-cloud-go/issues/9663)) ([67d353b](https://togithub.com/googleapis/google-cloud-go/commit/67d353beefe3b607c08c891876fbd95ab89e5fe3)), refs [#9670](https://togithub.com/googleapis/google-cloud-go/issues/9670) * **auth:** Add UniverseDomain to DetectOptions ([#9536](https://togithub.com/googleapis/google-cloud-go/issues/9536)) ([3618d3f](https://togithub.com/googleapis/google-cloud-go/commit/3618d3f7061615c0e189f376c75abc201203b501)) * **auth:** Make package externalaccount public ([#9633](https://togithub.com/googleapis/google-cloud-go/issues/9633)) ([a0978d8](https://togithub.com/googleapis/google-cloud-go/commit/a0978d8e96968399940ebd7d092539772bf9caac)) * **auth:** Move credentials to base auth package ([#9590](https://togithub.com/googleapis/google-cloud-go/issues/9590)) ([1a04baf](https://togithub.com/googleapis/google-cloud-go/commit/1a04bafa83c27342b9308d785645e1e5423ea10d)) * **auth:** Refactor public sigs to use Credentials ([#9603](https://togithub.com/googleapis/google-cloud-go/issues/9603)) ([69cb240](https://togithub.com/googleapis/google-cloud-go/commit/69cb240c530b1f7173a9af2555c19e9a1beb56c5)) ### Bug Fixes * **auth/oauth2adapt:** Update protobuf dep to v1.33.0 ([30b038d](https://togithub.com/googleapis/google-cloud-go/commit/30b038d8cac0b8cd5dd4761c87f3f298760dd33a)) * **auth:** Fix uint32 conversion ([9221c7f](https://togithub.com/googleapis/google-cloud-go/commit/9221c7fa12cef9d5fb7ddc92f41f1d6204971c7b)) * **auth:** Port sts expires fix ([#9618](https://togithub.com/googleapis/google-cloud-go/issues/9618)) ([7bec97b](https://togithub.com/googleapis/google-cloud-go/commit/7bec97b2f51ed3ac4f9b88bf100d301da3f5d1bd)) * **auth:** Read universe_domain from all credentials files ([#9632](https://togithub.com/googleapis/google-cloud-go/issues/9632)) ([16efbb5](https://togithub.com/googleapis/google-cloud-go/commit/16efbb52e39ea4a319e5ee1e95c0e0305b6d9824)) * **auth:** Remove content-type header from idms get requests ([#9508](https://togithub.com/googleapis/google-cloud-go/issues/9508)) ([8589f41](https://togithub.com/googleapis/google-cloud-go/commit/8589f41599d265d7c3d46a3d86c9fab2329cbdd9)) * **auth:** Update protobuf dep to v1.33.0 ([30b038d](https://togithub.com/googleapis/google-cloud-go/commit/30b038d8cac0b8cd5dd4761c87f3f298760dd33a)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
jbrichetto
pushed a commit
to openly-engineering/oauth2
that referenced
this pull request
May 22, 2024
This is a fix on the googleapis/google-cloud-go#9508. The aws provider in that library is a ported dependency from here. Change-Id: I28e1efa4fdb8292210b695a164a55060c83dae88 GitHub-Last-Rev: c425f2d GitHub-Pull-Request: golang#711 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/570875 Reviewed-by: Cody Oss <codyoss@google.com> Reviewed-by: Chris Smith <chrisdsmith@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detailed description here
https://issuetracker.google.com/issues/328089077