fixing broken test - cloud/spanner/SessionPoolIntegrationTest.java#2495
Conversation
googlebot
added
the
cla: yes
|
@vam-google Would you know why this test does not run on travis? That is why we never caught this issue. This is an integration test. |
|
@vkedia - added some more java style, unused and other fixes. |
|
I see this error in appveyor build: |
|
@vkedia - fixed missing import. |
* chore: update dependency versions in java templates * update other templates Source-Link: googleapis/synthtool@0b86c72 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:68ba5f5164a4b55529d358bb262feaa000536a0c62980727dd05a91bbb47ea5e Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…eapis#2496) Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - https://togithub.com/googleapis/java-bigtable/issues/2495 - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) (N/A) - [x] Rollback plan is reviewed and LGTMed (N/A) - [x] All new data plane features have a completed end to end testing plan (N/A) Fixes googleapis#2495 ☕️ If you write sample code, please follow the [samples format]( https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
3 participants
No description provided.