Minor javadoc updates, rename functionDefinition to content

gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/Field.java

@@ -219,7 +219,7 @@ public Builder type(Type type) {
     }
 
     /**
-     * Sets the mode of the field. By default {@link Mode#NULLABLE} is used.
+     * Sets the mode of the field. When not specified {@link Mode#NULLABLE} is used.
      */
     public Builder mode(Mode mode) {
       this.mode = mode;
@@ -235,7 +235,7 @@ public Builder description(String description) {
     }
 
     /**
-     * Creates an {@code Field} object.
+     * Creates a {@code Field} object.
      */
     public Field build() {
       return new Field(this);

gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/Schema.java

@@ -146,7 +146,6 @@ public static Builder builder() {
   }
 
   public static Schema of(Iterable<Field> fields) {
-    checkNotNull(fields);
     return builder().fields(fields).build();
   }
 

gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/TableInfo.java

@@ -258,7 +258,7 @@ public Builder externalConfiguration(ExternalDataConfiguration externalConfigura
     }
 
     /**
-     * Sets a user-friendly name for the dataset.
+     * Sets a user-friendly name for the table.
      */
     public Builder friendlyName(String friendlyName) {
       this.friendlyName = firstNonNull(friendlyName, Data.<String>nullOf(String.class));
@@ -291,8 +291,8 @@ Builder numRows(Long numRows) {
     }
 
     /**
-     * Sets the table's schema. Providing a schema is not necessary when {@link #viewQuery} is
-     * provided.
+     * Sets the table's schema. Providing a schema is not necessary when {@link #viewQuery(String)}
+     * or {@link #externalConfiguration(ExternalDataConfiguration)} are provided.
      */
     public Builder schema(Schema schema) {
       this.schema = schema;
@@ -380,7 +380,7 @@ public String etag() {
   }
 
   /**
-   * Returns an opaque id for the dataset.
+   * Returns an opaque id for the table.
    */
   public String id() {
     return id;

gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/UserDefinedFunction.java

@@ -44,30 +44,29 @@ public enum Type {
   }
 
   private final Type type;
-  private final String functionDefinition;
+  private final String content;
 
-  UserDefinedFunction(Type type, String functionDefinition) {
+  UserDefinedFunction(Type type, String content) {
     this.type = type;
-    this.functionDefinition = functionDefinition;
+    this.content = content;
   }
 
   public Type type() {
     return type;
   }
 
   /**
-   * Returns function's definition. If {@link #type()} is {@link Type#INLINE} this method returns
-   * a code blob. If {@link #type()} is {@link Type#FROM_URI} this method returns a Google Cloud
-   * Storage URI (e.g. gs://bucket/path).
+   * If {@link #type()} is {@link Type#INLINE} this method returns a code blob. If {@link #type()}
+   * is {@link Type#FROM_URI} the method returns a Google Cloud Storage URI (e.g. gs://bucket/path).
    */
-  public String functionDefinition() {
-    return functionDefinition;
+  public String content() {
+    return content;
   }
 
   /**
    * A Google Cloud BigQuery user-defined function, as a code blob.
    */
-  public static final class InlineFunction extends UserDefinedFunction {
+  static final class InlineFunction extends UserDefinedFunction {
 
     private static final long serialVersionUID = 1083672109192091686L;
 
@@ -77,20 +76,20 @@ public static final class InlineFunction extends UserDefinedFunction {
 
     @Override
     public String toString() {
-      return MoreObjects.toStringHelper(this).add("inlineCode", functionDefinition()).toString();
+      return MoreObjects.toStringHelper(this).add("inlineCode", content()).toString();
     }
 
     @Override
     public com.google.api.services.bigquery.model.UserDefinedFunctionResource toPb() {
       return new com.google.api.services.bigquery.model.UserDefinedFunctionResource()
-          .setInlineCode(functionDefinition());
+          .setInlineCode(content());
     }
   }
 
   /**
    * A Google Cloud BigQuery user-defined function, as an URI to Google Cloud Storage.
    */
-  public static final class UriFunction extends UserDefinedFunction {
+  static final class UriFunction extends UserDefinedFunction {
 
     private static final long serialVersionUID = 4660331691852223839L;
 
@@ -100,19 +99,19 @@ public static final class UriFunction extends UserDefinedFunction {
 
     @Override
     public String toString() {
-      return MoreObjects.toStringHelper(this).add("functionUri", functionDefinition()).toString();
+      return MoreObjects.toStringHelper(this).add("functionUri", content()).toString();
     }
 
     @Override
     public com.google.api.services.bigquery.model.UserDefinedFunctionResource toPb() {
       return new com.google.api.services.bigquery.model.UserDefinedFunctionResource()
-          .setResourceUri(functionDefinition());
+          .setResourceUri(content());
     }
   }
 
   @Override
   public int hashCode() {
-    return Objects.hash(type, functionDefinition);
+    return Objects.hash(type, content);
   }
 
   @Override

gcloud-java-bigquery/src/test/java/com/google/gcloud/bigquery/UserDefinedFunctionTest.java

@@ -30,9 +30,9 @@ public class UserDefinedFunctionTest {
 
   @Test
   public void testConstructor() {
-    assertEquals(INLINE, INLINE_FUNCTION.functionDefinition());
+    assertEquals(INLINE, INLINE_FUNCTION.content());
     assertEquals(UserDefinedFunction.Type.INLINE, INLINE_FUNCTION.type());
-    assertEquals(URI, URI_FUNCTION.functionDefinition());
+    assertEquals(URI, URI_FUNCTION.content());
     assertEquals(UserDefinedFunction.Type.FROM_URI, URI_FUNCTION.type());
   }
 
@@ -51,6 +51,6 @@ public void testToAndFromPb() {
   private void compareUserDefinedFunction(UserDefinedFunction expected, UserDefinedFunction value) {
     assertEquals(expected, value);
     assertEquals(expected.type(), value.type());
-    assertEquals(expected.functionDefinition(), value.functionDefinition());
+    assertEquals(expected.content(), value.content());
   }
 }