Skip to content

Added batch support to the local DNS helper. #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aozarov merged 5 commits into from
Apr 15, 2016
Merged

Added batch support to the local DNS helper. #925

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b783fe8
Added batch support to the local DNS helper.
mderka Apr 13, 2016
3eebaa8
Added one more combined test.
mderka Apr 14, 2016
0b168fb
Refactored boundary variables to be static attributes.
mderka Apr 15, 2016
e8aa3db
Switched to reading byte stream using scanner.
mderka Apr 15, 2016
5931b30
Added nested callback implementations in the test.
mderka Apr 15, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added one more combined test.
  • Loading branch information
@mderka
mderka committed Apr 14, 2016
commit 3eebaa807dc9d2b01c95774513b76b0fe35881c9
65 changes: 65 additions & 0 deletions gcloud-java-dns/src/test/java/com/google/cloud/dns/testing/LocalDnsHelperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2857,4 +2857,69 @@ public void onFailure(GoogleJsonError googleJsonError) {
DnsRpc.Option.SORTING_ORDER, "descending"));
batch.submit();
}

@Test
public void testCombined() {
final ManagedZone created = RPC.create(ZONE1, EMPTY_RPC_OPTIONS);
RpcBatch batch = RPC.createBatch();
batch.addListZones(new RpcBatch.Callback<ManagedZonesListResponse>() {
@Override
public void onSuccess(ManagedZonesListResponse response) {
assertEquals(1, response.getManagedZones().size());
assertEquals(created, response.getManagedZones().get(0));
}

@Override
public void onFailure(GoogleJsonError googleJsonError) {
fail();
}
}, EMPTY_RPC_OPTIONS);
batch.addGetZone(created.getName(), new RpcBatch.Callback<ManagedZone>() {
@Override
public void onSuccess(ManagedZone response) {
assertEquals(created, response);
}

@Override
public void onFailure(GoogleJsonError googleJsonError) {
fail();
}
}, EMPTY_RPC_OPTIONS);
batch.addListChangeRequests(created.getName(), new RpcBatch.Callback<ChangesListResponse>() {
@Override
public void onSuccess(ChangesListResponse response) {
assertEquals(1, response.getChanges().size());
assertEquals(RPC.getChangeRequest(created.getName(), "0", EMPTY_RPC_OPTIONS),
response.getChanges().get(0).getId());
}

@Override
public void onFailure(GoogleJsonError googleJsonError) {
fail();
}
}, EMPTY_RPC_OPTIONS);
batch.addListRecordSets(created.getName(),
new RpcBatch.Callback<ResourceRecordSetsListResponse>() {
@Override
public void onSuccess(ResourceRecordSetsListResponse response) {
assertEquals(2, response.getRrsets().size());
}

@Override
public void onFailure(GoogleJsonError googleJsonError) {
fail();
}
}, EMPTY_RPC_OPTIONS);
batch.addGetChangeRequest(created.getName(), "0", new RpcBatch.Callback<Change>() {
@Override
public void onSuccess(Change response) {
assertEquals(RPC.getChangeRequest(created.getName(), "0", EMPTY_RPC_OPTIONS),response);
}

@Override
public void onFailure(GoogleJsonError googleJsonError) {
fail();
}
}, EMPTY_RPC_OPTIONS);
}
}