pubsub: gRPC max recv set to 4MB

[chrisgoffinet]

Reproduce steps:

@google-cloud/pubsub: 0.3.0 0.9.0
Publish message > 4MB to a topic
Retrieve message through subscription: Error: Received message larger than max (6374241 vs. 4194304)

#2007 was pushed to fix the limits but the existing PubSub client seems to be still defaulting to 4MB. It was originally posted about on #1991 which was closed after #2007 was merged but still throwing that error.

[stephenplusplus]

That module is on version 0.9.0 now. Can you try upgrading?

[chrisgoffinet]

I made a typo when filling out this ticket, I am on version 0.9.0 not 0.3.0. So it's still failing there.

[chrisgoffinet]

Also confirmed by looking at node_modules, I see the change made on the gRPC side common-grpc/src/service.js, so it's definitely pulled in. Could this be an issue on PubSub server side?

[stephenplusplus]

Thanks for confirming.

@murgatroid99 I tried to remove the message limit with the changes in this PR: #2007 -- did I make a mistake, or could this error be coming from the API response?

[murgatroid99]

The options that you add in that PR are gRPC Client constructor arguments. They are supposed to be in the same object as the 'grpc.primary_user_agent' on line 802 of service.js.

[stephenplusplus]

Gotcha, thanks!

[stephenplusplus]

PR sent with a fix in #2192 -- good catch @chrisgoffinet!