-
Notifications
You must be signed in to change notification settings - Fork 677
Storage: clean up write streams #400
Copy link
Copy link
Closed
Labels
🚨This issue needs some love.This issue needs some love.api: storageIssues related to the Cloud Storage API.Issues related to the Cloud Storage API.triage meI really want to be triaged.I really want to be triaged.
Milestone
Metadata
Metadata
Assignees
Labels
🚨This issue needs some love.This issue needs some love.api: storageIssues related to the Cloud Storage API.Issues related to the Cloud Storage API.triage meI really want to be triaged.I really want to be triaged.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Looking at the file.createWritableStream, validation is intermixed with everything and some internal streams exist solely for validation purposes. We might want to consider having a fast-path for when
validation: falsewhich by-passes all this logic and extraneous streams. This should help with #397 whenvalidation: falsebut I'll put it in Storage Future because for the default and recommended case, it probably won't help much.