-
Notifications
You must be signed in to change notification settings - Fork 675
BigQuery's table.import() callback is invoked improperly #495
Copy link
Copy link
Closed
Labels
🚨This issue needs some love.This issue needs some love.api: bigqueryIssues related to the BigQuery API.Issues related to the BigQuery API.triage meI really want to be triaged.I really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Metadata
Metadata
Assignees
Labels
🚨This issue needs some love.This issue needs some love.api: bigqueryIssues related to the BigQuery API.Issues related to the BigQuery API.triage meI really want to be triaged.I really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Type
Fields
Give feedbackNo fields configured for issues without a type.
If you pass a string filename into BigQuery's
table.import()method, the callback is invoked with the improper arguments. The documentation says the callback should be called with this format:But it is actually invoked like this:
This is caused by improperly handling the
completeevent ofcreateWriteStream()on this line. The complete event fires with noerrorargument, but instead with thejobas the first argument. So just forwarding the arguments ontocallbackresults in the undocumented behavior.A PR with a fix is coming right up!