feat(Spanner): modify default maxConcurrentStreamsLowWatermark value … - #8933
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
alkatrivedi
commented
Jul 22, 2026
| "gcp-metadata": "^7.0.1", | ||
| "@sinonjs/fake-timers": "15.2.1" | ||
| "@sinonjs/fake-timers": "15.2.1", | ||
| "@eslint-community/eslint-utils": "<4.10.0" |
Contributor
Author
There was a problem hiding this comment.
need this change since, the package @eslint-community/eslint-utils (which is pulled in automatically by eslint via gts@6.0.2) recently released version 4.10.0.
In version 4.10.0, they updated their engines field in package.json to require Node.js ^20.19.0 || ^22.13.0 || >=24, effectively dropping support for Node 18.
Our GitHub Actions presubmit job is running Node v18.20.8. Because pnpm install is being executed with the --engine-strict flag, pnpm strictly enforces these Node engine requirements and immediately fails the installation.
rahul2393
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the default value of
maxConcurrentStreamsLowWatermarkfrom 100 to 25. This is to make the value consistent with Java client. As part of this change one channel can have at max 25 concurrent request at time, once the threshold will reach the channels will get scale up.