Skip to content

feat(Spanner): modify default maxConcurrentStreamsLowWatermark value … #8933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alkatrivedi merged 3 commits into from
Jul 23, 2026
Merged

feat(Spanner): modify default maxConcurrentStreamsLowWatermark value … #8933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82f69ec
feat(Spanner): modify default maxConcurrentStreamsLowWatermark value …
alkatrivedi Jul 22, 2026
cdbeb57
fix: presubmits
alkatrivedi Jul 22, 2026
f1b0340
Merge branch 'main' into dcp-watermark
alkatrivedi Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions handwritten/spanner/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,12 +139,14 @@
},
"overrides": {
"gcp-metadata": "^7.0.1",
"@sinonjs/fake-timers": "15.2.1"
"@sinonjs/fake-timers": "15.2.1",
"@eslint-community/eslint-utils": "<4.10.0"

@alkatrivedi alkatrivedi Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need this change since, the package @eslint-community/eslint-utils (which is pulled in automatically by eslint via gts@6.0.2) recently released version 4.10.0.
In version 4.10.0, they updated their engines field in package.json to require Node.js ^20.19.0 || ^22.13.0 || >=24, effectively dropping support for Node 18.
Our GitHub Actions presubmit job is running Node v18.20.8. Because pnpm install is being executed with the --engine-strict flag, pnpm strictly enforces these Node engine requirements and immediately fails the installation.

},
"pnpm": {
"overrides": {
"gcp-metadata": "^7.0.1",
"@sinonjs/fake-timers": "15.2.1"
"@sinonjs/fake-timers": "15.2.1",
"@eslint-community/eslint-utils": "<4.10.0"
}
},
"homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/spanner"
Expand Down
2 changes: 1 addition & 1 deletion handwritten/spanner/src/spanner_grpc_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"channelPool": {
"maxSize": 10,
"maxConcurrentStreamsLowWatermark": 100
"maxConcurrentStreamsLowWatermark": 25
},
"method": [
{
Expand Down
Loading