feat(firestore): Add support for 16MB documents - #8649
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Firestore client to support larger documents by increasing the gRPC max receive and send message lengths to 17MB and configuring flow control window sizes. It also adds a new integration test suite (large_document.ts) to verify handling of large documents (up to 15.9MB) and rejection of oversized payloads. The review feedback correctly identifies an issue in the oversized payload test where a successful write would throw a generic error that gets caught and fails on an unrelated assertion, masking the true failure; a cleaner assertion pattern is suggested.
wu-hui
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a regression is introduced by increasing the flow control window, this can be overwritten: