fix(gaxios): prevent comma corruption when draining stream error responses - #8779
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where stream error responses split across multiple chunks were corrupted with commas during string conversion. It updates the response parsing logic to join string chunks directly or concatenate them as Buffers if they contain non-string chunks. A test case was added to verify this behavior with string chunks. The reviewer suggested adding an additional test case using Buffer chunks to ensure full coverage of the fallback concatenation logic.
jerrylin3321
approved these changes
Jun 30, 2026
feywind
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this fix, we are hoping to address google-gemini/gemini-cli#21884 and #8768.
Credit to @jerrylin3321 for originally creating this branch. We are creating a PR to add a few additional changes on top of it.