chore: regenerate google-cloud-discoveryengine, google-cloud-dialogflow, and google-cloud-ces - #8815
Closed
suztomo wants to merge 1 commit into
Closed
Conversation
… and google-cloud-ces to librarian
yoshi-kokoro
removed
the
kokoro:run
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request consists of formatting and style cleanups across numerous auto-generated GAPIC test files in packages such as google-cloud-ces, google-cloud-dialogflow, and google-cloud-discoveryengine. The changes primarily collapse multi-line header checks into single lines and clean up union type declarations in callback signatures. I have no feedback to provide as these are standard formatting improvements.
suztomo
changed the title
Contributor
|
I am closing this PR because it uses an older version of googleapis for the generation, and the new content should also be addressed by #8821. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because generating all didn't create a reviewable pull request (googleapis/librarian#6638 (comment)), I regenerated google-cloud-discoveryengine, google-cloud-dialogflow, and google-cloud-ces using Librarian. They are 2nd, 3rd, and 4th largest libraries in google-cloud-node.
For googleapis/librarian#6638