feat(logging): split GAPIC from the logging handwritten package - #8929
Merged
feywind merged 4 commits intoJul 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes auto-generated GAPIC client files and configurations, transitioning the internal ./v2 module to an external dependency on @google-cloud/logging-api. Feedback suggests replacing the require statement for @google-cloud/logging-api with an ES6 import in src/index.ts to preserve TypeScript type safety and eliminate the need for an ESLint suppression comment.
quirogas
marked this pull request as ready for review
July 23, 2026 07:07
feywind
approved these changes
Jul 24, 2026
feywind
left a comment
Contributor
There was a problem hiding this comment.
Dunno if my review still counts, but...
westarle
pushed a commit
that referenced
this pull request
Aug 4, 2026
🤖 I have created a release *beep* *boop* --- ## [11.4.0](logging-v11.3.0...logging-v11.4.0) (2026-08-04) ### Features * **logging:** Split GAPIC from the logging handwritten package ([#8929](#8929)) ([ee21766](ee21766)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
shivanee-p
pushed a commit
that referenced
this pull request
Aug 4, 2026
🤖 I have created a release *beep* *boop* --- ## [11.4.0](logging-v11.3.0...logging-v11.4.0) (2026-08-04) ### Features * **logging:** Split GAPIC from the logging handwritten package ([#8929](#8929)) ([ee21766](ee21766)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decouple the handwritten Logging wrapper from the auto-generated GAPIC client layer by importing a standalone version of the GAPIC library. Standalone
-apipackages are now generated and maintained independently.src/v2/) and OwlBot files (owlbot.py,.OwlBot.yaml).@google-cloud/logging-api(^0.2.0).v2andprotosdirectly from@google-cloud/logging-api.v2GAPIC sub-clients (LoggingServiceV2Client,ConfigServiceV2Client,MetricsServiceV2Client).Internal: b/531788771