fix(gapic-node-processing): preserve index.ts exports and merge clients across multi-api staging subdirectories - #8953
Merged
quirogas merged 4 commits intoJul 23, 2026
Conversation
…ts across multi-api staging subdirectories Combine duplicate version barrel export files (src/v*/index.ts) using TypeScript AST parsing to prevent sequential gapic-generator passes from overwriting exports. Aggregate client class names across all staging subdirectories per version to ensure top-level index.ts re-exports all generated clients. For googleapis/librarian#6969
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces functionality to merge export statements across version index files when combining libraries, and refactors client/version extraction to use a map of sets to avoid duplicates. The review feedback suggests refining the version index file regex to prevent matching non-version directories (e.g., 'validators') and removing a redundant fs.stat call before fs.readFile to improve I/O efficiency.
…with structural path inspection and remove redundant fs.stat
quirogas
marked this pull request as ready for review
July 23, 2026 17:27
feywind
approved these changes
Jul 23, 2026
feywind
left a comment
feywind
left a comment
Contributor
There was a problem hiding this comment.
One quick double-check comment.
…in getClientsAndVersions
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combine duplicate version barrel export files (src/v*/index.ts) using TypeScript AST parsing to prevent sequential gapic-generator passes from overwriting exports. Aggregate client class names across all staging subdirectories per version to ensure top-level index.ts re-exports all generated clients.
For googleapis/librarian#6969