-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Check coverage across python runtimes #16211
Copy link
Copy link
Open
Labels
priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: cleanupAn internal cleanup or hygiene concern.An internal cleanup or hygiene concern.
Description
Recently, we have been adding conditionals that perform different logic depending on the python version or dependency versions (googleapis/gapic-generator-python#2477, googleapis/gapic-generator-python#2472)
Individual coverage checks aren't aware of the big picture, so individual runs often fail the coverage check, unless we add pragma: no cover statements
We should find a way to fix this at some point, to make sure we don't make a habit of adding no cover and losing required coverage
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: cleanupAn internal cleanup or hygiene concern.An internal cleanup or hygiene concern.