-
Notifications
You must be signed in to change notification settings - Fork 1.7k
test x-goog-request-params over REST #16425
Copy link
Copy link
Open
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: processA process-related concern. May include testing, release, or the like.A process-related concern. May include testing, release, or the like.
Description
If the new annotation google.api.routing (AIP 4222) is used (example), then I believe we need to include x-goog-request-params, with a value as specified in that annotation, over REST.
If no google.api.routing are presented, then it sounds like we could omit x-goog-request-params because the information would duplicate the URL.
UPDATE (2022-10-07): An internal discussion clarified we need to include x-goog-request-params no matter what, even in the REST case.
I'm not sure yet whether the Google use cases make this a P1. More discussion in the internal email thread.
This issue is split off from googleapis/gapic-generator-python#1444, which now focuses on the gRPC use case (though that fix will also be relevant to the implementation here).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: processA process-related concern. May include testing, release, or the like.A process-related concern. May include testing, release, or the like.