Skip to content

Implement 'bigquery.dataset.Dataset'. #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tseaver merged 12 commits into from
Jul 28, 2015
Merged

Implement 'bigquery.dataset.Dataset'. #1018

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
57c354e
Implement 'bigquery.dataset.Dataset'.
tseaver Jul 24, 2015
3d3b9e3
Don't send null values w/ resource body in 'create'/'update'.
tseaver Jul 24, 2015
5e3fd0c
Use words for native types.
tseaver Jul 27, 2015
6fdf1ef
Add an error message for ValueErrors.
tseaver Jul 27, 2015
f5015c4
Add ':raises' docs.
tseaver Jul 27, 2015
9860e3b
Use 'six.string_types' for a type check.
tseaver Jul 27, 2015
ff626b7
Replace overlooked str w/ 'string'.
tseaver Jul 28, 2015
43bafba
Restrict requested fields in 'Dataset.exists' API request.
tseaver Jul 28, 2015
9b2734b
Use 'six.integer_types' vs. 'int' for type check.
tseaver Jul 28, 2015
b846968
Note rationale for division of back-end's timestamp by 1000.0.
tseaver Jul 28, 2015
538aa92
Ensure property getters have ':rtype:'/':returns:' in docstrings.
tseaver Jul 28, 2015
81c05b7
Adhere to @dhermes' sensibility about formatting string usage.
tseaver Jul 28, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Restrict requested fields in 'Dataset.exists' API request. 
Addresses:
#1018 (comment)
  • Loading branch information
@tseaver
tseaver committed Jul 28, 2015
commit 43bafba08a3c14c803718ac3c3808fdced8d28f1
3 changes: 2 additions & 1 deletion gcloud/bigquery/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,8 @@ def exists(self, client=None):
client = self._require_client(client)

try:
client.connection.api_request(method='GET', path=self.path)
client.connection.api_request(method='GET', path=self.path,
query_params={'fields': 'id'})
except NotFound:
return False
else:
Expand Down
2 changes: 2 additions & 0 deletions gcloud/bigquery/test_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ def test_exists_miss_w_bound_client(self):
req = conn._requested[0]
self.assertEqual(req['method'], 'GET')
self.assertEqual(req['path'], '/%s' % PATH)
self.assertEqual(req['query_params'], {'fields': 'id'})

def test_exists_hit_w_alternate_client(self):
PATH = 'projects/%s/datasets/%s' % (self.PROJECT, self.DS_NAME)
Expand All @@ -207,6 +208,7 @@ def test_exists_hit_w_alternate_client(self):
req = conn2._requested[0]
self.assertEqual(req['method'], 'GET')
self.assertEqual(req['path'], '/%s' % PATH)
self.assertEqual(req['query_params'], {'fields': 'id'})

def test_reload_w_bound_client(self):
PATH = 'projects/%s/datasets/%s' % (self.PROJECT, self.DS_NAME)
Expand Down