Skip to content

fix: update resume token for restarting BiDi streams #10282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crwilcox merged 4 commits into from
Jan 31, 2020
Merged

fix: update resume token for restarting BiDi streams #10282

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eb98435
fix: fetch updated resume tokens for restarting of stream
crwilcox Jan 29, 2020
19a7e59
fix: Improve DummyRPC to call initial_request when necessary
crwilcox Jan 29, 2020
3c170a3
fix: rename method to reflect request is not initial only
crwilcox Jan 31, 2020
a20b5d8
fix: adjust test to use new function name
crwilcox Jan 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: adjust test to use new function name
  • Loading branch information
@crwilcox
crwilcox committed Jan 31, 2020
commit a20b5d88fd0cbb3e9950d3ceb198a594b8aa90e6
2 changes: 1 addition & 1 deletion firestore/tests/unit/v1/test_watch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,7 +779,7 @@ def test__reset_docs(self):
def test_resume_token_sent_on_recovery(self):
inst = self._makeOne()
inst.resume_token = b"ABCD0123"
request = inst._get_initial_request()
request = inst._get_rpc_request()
self.assertEqual(request.add_target.resume_token, b"ABCD0123")


Expand Down