Skip to content

Fix conversion of backend-generated timestamps #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tseaver merged 4 commits into from
Sep 11, 2015
Merged

Fix conversion of backend-generated timestamps #1128

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e004a76
Fix conversion of backend-generated timestamp values.
tseaver Sep 8, 2015
bda4cfb
Fix reference docs URLs.
tseaver Sep 8, 2015
d77d956
Use utility function from 'gcloud._helpers' to convert timestamps.
tseaver Sep 10, 2015
8225dd8
Don't replace timestamp w/ UTC.
tseaver Sep 11, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Don't replace timestamp w/ UTC. 
'_datetime_from_microseconds' already does that.

Addresses:
#1128 (comment)
  • Loading branch information
@tseaver
tseaver committed Sep 11, 2015
commit 8225dd882baf6ea071aed10e9f953a06ec715fd8
4 changes: 1 addition & 3 deletions gcloud/bigquery/table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

import six

from gcloud._helpers import UTC
from gcloud._helpers import _datetime_from_microseconds
from gcloud._helpers import _millis_from_datetime
from gcloud.exceptions import NotFound
Expand Down Expand Up @@ -763,8 +762,7 @@ def _bool_from_json(value, field):
def _datetime_from_json(value, field):
if _not_null(value, field):
# value will be a float in seconds, to microsecond precision, in UTC.
stamp = _datetime_from_microseconds(1e6 * float(value))
return stamp.replace(tzinfo=UTC)
return _datetime_from_microseconds(1e6 * float(value))


def _record_from_json(value, field):
Expand Down