Skip to content

Merging in datastore-v1beta3 branch. #1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhermes merged 31 commits into from
Apr 1, 2016
Merged

Merging in datastore-v1beta3 branch. #1688

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
64c28fd
Updating datastore URI template for v1beta3.
dhermes Jan 21, 2016
712077e
Removing use of isolation level in datastore.
dhermes Jan 3, 2016
323eff8
Renaming Makefile dirs to be Bigtable specific.
dhermes Jan 7, 2016
3fbe2ec
Upgrading Makefile to generate datastore v1beta3.
dhermes Jan 7, 2016
62abc15
Updating lint rules to account for new generated files.
dhermes Jan 7, 2016
5e6ab59
Using more descriptive shell var names in Makefile.
dhermes Feb 12, 2016
77322e0
Renaming dataset_id->project_id on PartitionId.
dhermes Jan 7, 2016
9957fb5
Renaming namespace->namespace_id on PartitionId.
dhermes Jan 7, 2016
a2493e2
Rename Value.indexed->exclude_from_indexes.
dhermes Jan 15, 2016
f734f0a
Renaming datastore operation->op on CompositeFilter and PropertyFilter.
dhermes Jan 7, 2016
ad509aa
Renaming filter->filters in CompositeFilter.
dhermes Jan 7, 2016
bced58c
Updating to new default for CompositeFilter.Operator.
dhermes Jan 7, 2016
47540b8
Updating to new default for ReadOptions.ReadConsistency.
dhermes Jan 7, 2016
eccd475
Renaming group_by->distinct_on in Query.
dhermes Jan 7, 2016
de20e17
Updating Query.limit from int32 to google.protobuf.Int32Value.
dhermes Jan 7, 2016
01a6b3c
Renaming entity_result->entity_results in QueryResultBatch.
dhermes Jan 7, 2016
b925c1a
Renaming key->keys in AllocateIdsResponse/AllocateIdsRequest.
dhermes Jan 7, 2016
43ba890
Renaming key->keys in LookupRequest.
dhermes Jan 7, 2016
e7a6e20
Renaming path_element->path in Key.
dhermes Jan 7, 2016
08789e3
Upgrading Entity.property to properties map in datastore.
dhermes Jan 7, 2016
8f06584
Upgrading timestamp_microseconds_value to timestamp_value.
dhermes Jan 7, 2016
58855a3
Upgrading list_value -> array_value for v1beta3.
dhermes Jan 7, 2016
ff76cb4
Updating CommitRequest, Mutation and helpers for v1beta3.
dhermes Jan 7, 2016
1f17183
Follow-on commit to clean-up out-of-sync code.
dhermes Feb 13, 2016
10c4393
Using WhichOneof when parsing a Value protobuf.
dhermes Feb 13, 2016
2336b8f
Adding support for null and geo point values in v1beta3.
dhermes Feb 13, 2016
c0a5306
Removing custom dataset ID environment variable.
dhermes Feb 13, 2016
ba8c262
Removing hacks that avoid using project ID in key protos.
dhermes Feb 13, 2016
4524b53
Removing checks for dataset ID prefixes.
dhermes Feb 13, 2016
44e12b1
Parse Datastore error message using Status protocol buffer.
pcostell Mar 15, 2016
8538095
Merge branch master into datastore-v1beta3
dhermes Apr 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Follow-on commit to clean-up out-of-sync code. 
The sync-failure was caused by breaking up the v1beta3
changes into distinct and small changes.
  • Loading branch information
@dhermes
dhermes committed Mar 28, 2016
commit 1f17183648b17fc390225946c621d43298e63d5a
3 changes: 1 addition & 2 deletions gcloud/datastore/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

import os

from gcloud._helpers import _has_field
from gcloud import connection
from gcloud.environment_vars import GCD_HOST
from gcloud.exceptions import make_exception
Expand Down Expand Up @@ -436,5 +435,5 @@ def _parse_commit_response(commit_response_pb):
mut_results = commit_response_pb.mutation_results
index_updates = commit_response_pb.index_updates
completed_keys = [mut_result.key for mut_result in mut_results
if _has_field(mut_result, 'key')]
if mut_result.HasField('key')] # Message field (Key)
return index_updates, completed_keys
1 change: 0 additions & 1 deletion gcloud/datastore/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import six

from gcloud._helpers import _datetime_to_pb_timestamp
from gcloud._helpers import _has_field
from gcloud._helpers import _pb_timestamp_to_datetime
from gcloud.datastore._generated import entity_pb2 as _entity_pb2
from gcloud.datastore.entity import Entity
Expand Down
14 changes: 8 additions & 6 deletions gcloud/datastore/test_batch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,10 @@ def test_put_entity_w_completed_key(self):
self.assertFalse(prop_dict['foo'].exclude_from_indexes)
self.assertTrue(prop_dict['baz'].exclude_from_indexes)
self.assertFalse(prop_dict['spam'].exclude_from_indexes)
self.assertTrue(prop_dict['spam'].list_value[0].exclude_from_indexes)
self.assertTrue(prop_dict['spam'].list_value[1].exclude_from_indexes)
self.assertTrue(prop_dict['spam'].list_value[2].exclude_from_indexes)
spam_values = prop_dict['spam'].array_value.values
self.assertTrue(spam_values[0].exclude_from_indexes)
self.assertTrue(spam_values[1].exclude_from_indexes)
self.assertTrue(spam_values[2].exclude_from_indexes)
self.assertFalse('frotz' in prop_dict)

def test_put_entity_w_completed_key_prefixed_project(self):
Expand Down Expand Up @@ -155,9 +156,10 @@ def test_put_entity_w_completed_key_prefixed_project(self):
self.assertFalse(prop_dict['foo'].exclude_from_indexes)
self.assertTrue(prop_dict['baz'].exclude_from_indexes)
self.assertFalse(prop_dict['spam'].exclude_from_indexes)
self.assertTrue(prop_dict['spam'].list_value[0].exclude_from_indexes)
self.assertTrue(prop_dict['spam'].list_value[1].exclude_from_indexes)
self.assertTrue(prop_dict['spam'].list_value[2].exclude_from_indexes)
spam_values = prop_dict['spam'].array_value.values
self.assertTrue(spam_values[0].exclude_from_indexes)
self.assertTrue(spam_values[1].exclude_from_indexes)
self.assertTrue(spam_values[2].exclude_from_indexes)
self.assertFalse('frotz' in prop_dict)

def test_delete_w_partial_key(self):
Expand Down
2 changes: 1 addition & 1 deletion gcloud/datastore/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,7 @@ def test_delete_multi_no_batch(self):
commit_req, transaction_id) = client.connection._commit_cw[0]
self.assertEqual(project, self.PROJECT)

mutated_key = _mutated_pb(self, commit_req_pb.mutations, 'delete')
mutated_key = _mutated_pb(self, commit_req.mutations, 'delete')
self.assertEqual(mutated_key, key.to_protobuf())
self.assertTrue(transaction_id is None)

Expand Down
2 changes: 1 addition & 1 deletion gcloud/datastore/test_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ def test_inverts_to_protobuf(self):
array_val1.exclude_from_indexes = False
array_val1.meaning = meaning = 22
array_val1.blob_value = b'\xe2\x98\x83'
array_val2 = val_pb4.array_value.add()
array_val2 = val_pb4.array_value.values.add()
array_val2.exclude_from_indexes = False
array_val2.meaning = meaning
array_val2.blob_value = b'\xe2\x98\x85'
Expand Down