Skip to content

fix(storage): fix test_mrd_concurrent_download_cancellation#17151

Merged
chandra-siri merged 1 commit into
mainfrom
mrd-test-failure
May 18, 2026
Merged

fix(storage): fix test_mrd_concurrent_download_cancellation#17151
chandra-siri merged 1 commit into
mainfrom
mrd-test-failure

Conversation

@nidhiii-27
Copy link
Copy Markdown
Contributor

@nidhiii-27 nidhiii-27 commented May 15, 2026

The test test_mrd_concurrent_download_cancellation is failing specifically because the download was successful before the test could cancel it.

  • Increased object_size from 5MB to 20MB and adjusted num_chunks to 40 (resulting in 500KB per chunk).

Error:

             for i in range(num_chunks):
Step #3 - "run-tests-and-delete-vm":                 if i % 2 == 0:
Step #3 - "run-tests-and-delete-vm": >                   assert isinstance(results[i], asyncio.CancelledError)
Step #3 - "run-tests-and-delete-vm": E                   AssertionError: assert False
Step #3 - "run-tests-and-delete-vm": E                    +  where False = isinstance(None, <class 'asyncio.exceptions.CancelledError'>)
Step #3 - "run-tests-and-delete-vm": E                    +    where <class 'asyncio.exceptions.CancelledError'> = asyncio.CancelledError
Step #3 - "run-tests-and-delete-vm": 
Step #3 - "run-tests-and-delete-vm": tests/system/test_zonal.py:904: AssertionError

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the test_mrd_concurrent_download_cancellation system test by increasing the test object size to 20MB and reducing the number of chunks to 40. It also modifies the asyncio.sleep duration to 0 to yield control to the event loop immediately before canceling tasks. I have no feedback to provide as there are no review comments.

@chandra-siri chandra-siri self-assigned this May 18, 2026
@chandra-siri chandra-siri marked this pull request as ready for review May 18, 2026 04:41
@chandra-siri chandra-siri requested a review from a team as a code owner May 18, 2026 04:41
@chandra-siri chandra-siri merged commit 9ba049a into main May 18, 2026
31 checks passed
@chandra-siri chandra-siri deleted the mrd-test-failure branch May 18, 2026 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants