Drop the ultra-flaky test for orphaned subscriptions. by tseaver · Pull Request #2215 · googleapis/google-cloud-python

tseaver · 2016-08-28T17:31:22Z

See:
#2080 (comment)

Closes #2080.

daspecster · 2016-08-29T01:23:23Z

In #2080 (comment), you mentioned there are other tests that cover this case?

Otherwise LGTM. I agree we need to get the build green with as few logical gaps in test coverage as possible.

I wonder if we should have some kind of secondary set of system tests? It might be nice to track these kinds of issues for the upstream guys?

tseaver · 2016-08-29T02:04:55Z

@daspecster Another option would be to mark the test with @unittest.expectedFailure.

dhermes · 2016-08-29T17:09:29Z

See my comment on #2080. Let's hold off on merging this until we can get @tmatsuo to weigh in (or until a fixed time interval passes not hearing from him)

tseaver · 2016-08-29T19:29:48Z

@dhermes WDYT of leaving it in place, but decorating it with @unittest.expected_failure? The back-end folks could use to to investigate, and meanwhile we would be green.

dhermes · 2016-08-29T19:36:24Z

Seems mostly OK. But an issue needs to be filed to follow up and fix it.

tseaver · 2016-08-29T19:42:11Z

#2080 would stay open if we followed that route: ideally, we would assign it to @tmatsuo.

dhermes · 2016-08-29T19:42:54Z

OK

Allows our tests to go green while the back-end investigates. Also, drop the ultra-flaky 'self.assertFalse(topic.exists())' in 'test_list_subscriptions'. It is redundant (names are unique), and dropping it lets the test pass normally. Toward #2080, #2111.

tseaver · 2016-08-29T21:49:11Z

I just backed out the "delete the test" change and marked it with unittest.expectedFailure.

I also dropped the self.assertFalse(topic.exists()) (see #2111).

system_tests/pubsub.py

    def test_list_subscriptions(self):
        TOPIC_NAME = 'list-sub' + unique_resource_id('-')
        topic = Config.CLIENT.topic(TOPIC_NAME)
-        self.assertFalse(retry_unavailable(topic.exists)())


dhermes · 2016-09-01T22:30:30Z

Go ahead and merge

…mples#2215)

tseaver added api: pubsub Issues related to the Pub/Sub API. flaky labels Aug 28, 2016

tseaver assigned daspecster and dhermes Aug 28, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 28, 2016

daspecster mentioned this pull request Aug 29, 2016

Add retry for flaky 'topic.exists()' check. #2214

Merged

dhermes reviewed Aug 30, 2016
View reviewed changes

tseaver merged commit efe359a into googleapis:master Sep 2, 2016

tseaver deleted the 2080-pubsub-drop-flaky-orphan-test branch September 2, 2016 12:50

tseaver mentioned this pull request Sep 6, 2016

Pubsub system test: test_fetch_delete_subscription_w_deleted_topic does not see orphan w/o topic #2080

Closed

dhermes mentioned this pull request Sep 19, 2016

Cut 0.19.0 release. #2270

Merged

theacodes unassigned daspecster and dhermes Sep 28, 2018

parthea pushed a commit that referenced this pull request Sep 22, 2023

update streaming samples [(#2215)](GoogleCloudPlatform/python-docs-sa…

b686c70

…mples#2215)

parthea added a commit that referenced this pull request Nov 24, 2025

feat: Add support for Python 3.13 (#2215)

866025a

Conversation

tseaver commented Aug 28, 2016

Uh oh!

daspecster commented Aug 29, 2016

Uh oh!

tseaver commented Aug 29, 2016

Uh oh!

dhermes commented Aug 29, 2016

Uh oh!

tseaver commented Aug 29, 2016

Uh oh!

dhermes commented Aug 29, 2016

Uh oh!

tseaver commented Aug 29, 2016

Uh oh!

dhermes commented Aug 29, 2016

Uh oh!

tseaver commented Aug 29, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Sep 1, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants