Adding 409 retry on bucket delete in BigQuery system test.#2310
Merged
dhermes merged 1 commit intogoogleapis:masterfrom Sep 15, 2016
Merged
Adding 409 retry on bucket delete in BigQuery system test.#2310dhermes merged 1 commit intogoogleapis:masterfrom
dhermes merged 1 commit intogoogleapis:masterfrom
Conversation
Contributor
Author
|
I'm not sure if we should check more than 409, there isn't much in the error: >>> print(json.dumps(exc._errors, indent=2))
[
{
"domain": "global",
"message": "The bucket you tried to delete was not empty.",
"reason": "conflict"
}
]
>>> exc.message
u'The bucket you tried to delete was not empty. (DELETE https://www.googleapis.com/storage/v1/b/{BUCKET})' |
Contributor
|
409 could in theory...have many different messages attached to it. Could we retry but also log/print the message incase it changes? |
Contributor
|
Otherwise LGTM if you don't think we should log it. |
Contributor
Author
Sure, but we wouldn't see it on CI, unless it failed. I've been meaning to make the |
Contributor
|
LGTM |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As with #2307, I took down a bunch of failures last week and can't track down where this occurred, sorry.