Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
240e9d6
Science fiction for expense report example application.
tseaver Aug 28, 2014
6a913d3
Update science-fiction CLI.
tseaver Oct 3, 2014
580fb03
Initial CLI skeleton to support datastore narrative example.
tseaver Oct 3, 2014
01d8f95
PEP8
tseaver Oct 9, 2014
6426aba
Suppress two useless PEP8 errors.
tseaver Oct 9, 2014
943f9df
Progress toward sample implementation.
tseaver Oct 13, 2014
e95392e
Get exp report creation actually working.
tseaver Oct 20, 2014
4f8c242
Use same Oauth envvars as regression tests.
tseaver Oct 22, 2014
d9c3af1
Enforce distinction between creating / updating expense reports.
tseaver Oct 22, 2014
afb287e
Add 'delete' command.
tseaver Oct 22, 2014
e836913
Add checks for valid report status to update / delete commands.
tseaver Oct 22, 2014
ebae693
Record metadata (description, created, updated) for expense reports.
tseaver Oct 22, 2014
666b6a4
Make 'review_expenses list' work with live data.
tseaver Oct 22, 2014
578d40a
Make 'review_expenses show' work with live data.
tseaver Oct 22, 2014
31dd159
Housekeeping.
tseaver Oct 22, 2014
7da8592
Reconcile command output w/ Sphinx.
tseaver Oct 22, 2014
7a58c95
Drop unneeded base exception.
tseaver Oct 22, 2014
b209068
Get 'review_expenses {approve,reject}' working w/ live data.
tseaver Oct 22, 2014
a98b440
Wire in the datastore narrative example.
tseaver Oct 22, 2014
42ecfe8
'csv' is not a known highlight syntax.
tseaver Oct 22, 2014
10e9f9f
Describe top-down flow of creating an expense report from a CSV file.
tseaver Oct 22, 2014
5090a3b
Add narrative for 'update_report'.
tseaver Oct 22, 2014
44812da
Typos, clarifications.
tseaver Oct 23, 2014
911ed7c
Add discussion of 'review_expenses list'.
tseaver Oct 23, 2014
8eadf43
Require 'employee_id' arg for 'review_expenses show'.
tseaver Oct 23, 2014
7f38c3a
Add discussion of 'review_expenses show'.
tseaver Oct 23, 2014
239d86f
Add discussion of 'review_expenses {approve,reject}'.
tseaver Oct 23, 2014
021b797
Cross-ref overview narrative to functional sections.
tseaver Oct 23, 2014
1579110
Add discussion of 'submit_expenses delete'.
tseaver Oct 23, 2014
4879512
Typo.
tseaver Oct 23, 2014
bdc32ab
Revert "Suppress two useless PEP8 errors."
tseaver Oct 23, 2014
bf5e420
PEP8.
tseaver Oct 23, 2014
b7e7f9c
pylint (reduced set, as in tests / demos / regression).
tseaver Oct 23, 2014
64cc17a
Typos.
tseaver Oct 23, 2014
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Get exp report creation actually working.
  • Loading branch information
tseaver committed Oct 23, 2014
commit e95392efcc00b8eea6192a6102adb9b16f04c35b
2 changes: 1 addition & 1 deletion docs/examples/expenses/expenses-20140901.csv
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
"Date","Vendor","Type","Quantity","Price","Memo"
"2014-08-26","United Airlines","Travel",1,425.00,"Airfaire, IAD <-> SFO"
"2014-08-27","Yellow Cab","Travel",32.00,"Taxi to IAD"
"2014-08-27","Yellow Cab","Travel",1,32.00,"Taxi to IAD"
20 changes: 11 additions & 9 deletions docs/examples/expenses/expenses/__init__.py
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
# package
import os

from gcloud import dataset
from gcloud.dataset.key import Key
from gcloud.dataset.query import Query
from gcloud import datastore
from gcloud.datastore.key import Key
from gcloud.datastore.entity import Entity
from gcloud.datastore.query import Query

def get_dataset():
client_email = os.environ['EXPENSES_CLIENT_EMAIL']
private_key_path = os.environ['EXPENSES_PRIVATE_KEY_PATH']
dataset_id = os.environ['EXPENSES_DATASET_ID']
conn = dataset.get_connection(client_email, private_key_path)
return conn.dataset_id(dataset_id)
conn = datastore.get_connection(client_email, private_key_path)

This comment was marked as spam.

return conn.dataset(dataset_id)

def get_employee(dataset, employee_id):
key = Key(dataset, path=[{'kind': 'Employee', 'name': employee_id}])
Expand All @@ -36,15 +37,16 @@ def upsert_report(employee_id, report_id, rows):
with dataset.transaction():
employee = get_employee(dataset, employee_id)
report = get_report(dataset, employee_id, report_id)
query = Query('Expense Item', dataset.connection())
query = Query('Expense Item', dataset)
# Delete any existing items.
for existing in query.ancestor(report.key()).fetch():
existing.delete()
# Add items based on rows.
report_path = report.key().path()
for i, row in enumerate(rows):
path = report.key.path() + [{'kind': 'Expense Item', 'id': i}]
path = report_path + [{'kind': 'Expense Item', 'id': i + 1}]
key = Key(dataset, path=path)
item = dataset.entity('Expense Item').key(key)
for k, v in rows.items():
item = Entity(dataset, 'Expense Item').key(key)
for k, v in row.items():
item[k] = v
item.save()
6 changes: 5 additions & 1 deletion docs/examples/expenses/expenses/scripts/submit_expenses.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
import sys


from .. import upsert_report


class InvalidCommandLine(ValueError):
pass

Expand Down Expand Up @@ -67,13 +70,14 @@ def __init__(self, submitter, *args):
if self.report_id is None:
fn = os.path.basename(self.filename)
base, ext = os.path.splitext(fn)
self.report_id = "%s/%s" % (self.employee_id, base)
self.report_id = base


class CreateReport(_Command):
"""Create an expense report from a CSV file.
"""
def __call__(self):
upsert_report(self.employee_id, self.report_id, self.rows)
self.submitter.blather("Processed %d rows." % len(self.rows))
self.submitter.blather("Created, report ID: %s" % self.report_id)

Expand Down