Skip to content

Fix #260: break datastore cycles by moving 'from_protobuf' classmethods #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tseaver merged 5 commits into from
Oct 23, 2014
Merged

Fix #260: break datastore cycles by moving 'from_protobuf' classmethods #289

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
949df73
Rename datastore._helpers -> helpers.
tseaver Oct 23, 2014
d1e1dd3
Fix #260: remove import cycles in datastore.
tseaver Oct 23, 2014
f330550
Enforce cycle checking.
tseaver Oct 23, 2014
a00e00e
Update 'gcloud.datastore.helpers' to indicate API-ness.
tseaver Oct 23, 2014
15cd8a2
Use longer name for list-comprehension placeholder.
tseaver Oct 23, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update 'gcloud.datastore.helpers' to indicate API-ness. 
Correct docstring.

Add '__all__' to indicate public members.
  • Loading branch information
@tseaver
tseaver committed Oct 23, 2014
commit a00e00ee09460e1dde12811f540ef54cc1a6a80b
4 changes: 3 additions & 1 deletion gcloud/datastore/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
"""Helper functions for dealing with Cloud Datastore's Protobuf API.

These functions are *not* part of the API.
The non-private functions are part of the API.
"""
__all__ = ('entity_from_protobuf', 'key_from_protobuf')

import calendar
import datetime

Expand Down