Bump storage to 1.4.0#3869
Merged
lukesneeringer merged 2 commits intogoogleapis:masterfrom Aug 24, 2017
Merged
Conversation
googlebot
added
the
cla: yes
dhermes
approved these changes
Aug 24, 2017
Contributor
dhermes
left a comment
dhermes
left a comment
There was a problem hiding this comment.
LGTM
Worth noting: Your release note style is somewhat different than what I've used over the years. This is neither good nor bad, just worth noting. (You can design a "sentiment" if you please.)
Contributor
Author
|
Tacking to your style for now; can discuss at repo split but I think what you are doing is fine. (Eventually I may want to automate it.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes:
requestsminimum bound to 2.18.0 (Bump requests minimum bound to 2.18.0 #3748)latest/directory for docs instead ofstable/(Use latest/ directory for docs instead of stable/ #3766)google.cloud.iteratortogoogle.api.core.page_iterator(Move google.cloud.iterator to google.api.core.page_iterator #3770)Bucket.patch()send them. (Storage: Track deleted labels; make Bucket.patch() send them. #3737)blob.py(Update reference to bytes signing issue in blob.py #3816)