Skip to content

bigquery: rename name field of Dataset to dataset_id #3955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jba merged 3 commits into from
Sep 14, 2017
Merged

bigquery: rename name field of Dataset to dataset_id #3955

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a431e52
bigquery: rename name field of Dataset to dataset_id
jba Sep 14, 2017
c239602
fix long line
jba Sep 14, 2017
6054c3b
fix long line
jba Sep 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix long line
  • Loading branch information
@jba
jba committed Sep 14, 2017
commit 6054c3b24bd5b3a78b2fc1973a2673b6ce984a2d
3 changes: 2 additions & 1 deletion bigquery/tests/unit/test_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2230,7 +2230,8 @@ def _call_fut(source_format, schema, dataset, name):

def test_empty_schema(self):
source_format = 'AVRO'
dataset = mock.Mock(project='prediction', spec=['dataset_id', 'project'])
dataset = mock.Mock(project='prediction',
spec=['dataset_id', 'project'])
dataset.dataset_id = 'market' # mock.Mock() treats `name` specially.
table_name = 'chairs'
metadata = self._call_fut(source_format, [], dataset, table_name)
Expand Down