#899: Harden 'Subscription.pull' against missing 'receivedMessages' in response#901
#899: Harden 'Subscription.pull' against missing 'receivedMessages' in response#901tseaver merged 1 commit intogoogleapis:masterfrom tseaver:899-pubsub-subscription_pull_wo_receivedMessages
Conversation
|
LGTM |
…receivedMessages #899: Harden 'Subscription.pull' against missing 'receivedMessages' in response
|
I think this has been reintroduced. I'm seeing the following in version 0.13.0: Exception in thread Thread-236: |
|
Hi, when are you going to release new version with this change? |
|
We can cut a release this week. @tseaver WDYT? |
|
Sure, no problem making a release soonish. |
|
@tseaver It would be great that you will release in these few days. Thank you! |
* feat: link stream to use _Connection and add unit tests * docstring * fix unit test in python 3.7 * add system test * lint * correct location for system test * fix system test * address comments * use dict for closing connections * switch back to use local variable for closed connections * removed unused variable
* feat: link stream to use _Connection and add unit tests * docstring * fix unit test in python 3.7 * add system test * lint * correct location for system test * fix system test * address comments * use dict for closing connections * switch back to use local variable for closed connections * removed unused variable
Fixes #899.