Skip to content

#903: Ensure transaction ID is passed through to connection during commit.#904

Merged
tseaver merged 1 commit intogoogleapis:masterfrom
tseaver:903-pass_xact_id_during_commit
Jun 1, 2015
Merged

#903: Ensure transaction ID is passed through to connection during commit.#904
tseaver merged 1 commit intogoogleapis:masterfrom
tseaver:903-pass_xact_id_during_commit

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 1, 2015

Fixes #903.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 1, 2015
@dhermes
Copy link
Contributor

dhermes commented Jun 1, 2015

LGTM. Seems leakier than need be (i.e. we could put the ID in the commit signature and Batch wouldn't need to know about the ID)

Pretty scary that was happening

@tseaver
Copy link
Contributor Author

tseaver commented Jun 1, 2015

Having transaction_id in the signature of Transaction.commit would be pretty silly.

My initial pass gave Batch.commit() an optional _transaction_id parameter, documented as "for use only by Transaction.commit(), but pylint put the kibosh on it (it doesn't want the subclass to have a different signature than the superclass.

tseaver added a commit that referenced this pull request Jun 1, 2015
@tseaver
Merge pull request #904 from tseaver/903-pass_xact_id_during_commit
9491053 
#903: Ensure transaction ID is passed through to connection during commit.
@tseaver tseaver merged commit 9491053 into googleapis:master Jun 1, 2015
@tseaver tseaver deleted the 903-pass_xact_id_during_commit branch June 1, 2015 16:02
@coveralls
Copy link

coveralls commented Jun 1, 2015

Coverage Status

Changes Unknown when pulling 164e1d8 on tseaver:903-pass_xact_id_during_commit into * on GoogleCloudPlatform:master*.

@dhermes dhermes mentioned this pull request Jun 4, 2015
Merged
atulep pushed a commit that referenced this pull request Apr 6, 2023
@danaharon @busunkim96
Update transcribe_async.py to have long GCS flac example [(#904)](Goo…
2eaa343 
…gleCloudPlatform/python-docs-samples#904)
atulep pushed a commit that referenced this pull request Apr 6, 2023
@danaharon @busunkim96
Update transcribe_async.py to have long GCS flac example [(#904)](Goo…
9852bb8 
…gleCloudPlatform/python-docs-samples#904)
atulep pushed a commit that referenced this pull request Apr 18, 2023
@danaharon @busunkim96
Update transcribe_async.py to have long GCS flac example [(#904)](Goo…
b47c459 
…gleCloudPlatform/python-docs-samples#904)
parthea pushed a commit that referenced this pull request Jul 6, 2023
@danaharon @busunkim96
Update transcribe_async.py to have long GCS flac example [(#904)](Goo…
9eee96a 
…gleCloudPlatform/python-docs-samples#904)
parthea pushed a commit that referenced this pull request Oct 22, 2023
@danaharon @busunkim96
Update transcribe_async.py to have long GCS flac example [(#904)](Goo…
0a1d7bb 
…gleCloudPlatform/python-docs-samples#904)
parthea added a commit that referenced this pull request Aug 21, 2025
@parthea
chore: remove unused files (#904)
42b7f92
parthea added a commit that referenced this pull request Sep 16, 2025
@parthea
chore: remove unused files (#904)
b1cd8e1
parthea pushed a commit that referenced this pull request Nov 24, 2025
@gkevinzheng
test: Fixed unsupported resource type in system test (#904)
a0a4a31
parthea pushed a commit that referenced this pull request Nov 24, 2025
@gcf-owl-bot
build: [autoapprove] bump cryptography from 41.0.2 to 41.0.3 (#904)
3a7ebe9 
Source-Link: googleapis/synthtool@352b9d4
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3e3800bb100af5d7f9e810d48212b37812c1856d20ffeafb99ebe66461b61fc7

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 25, 2025
@gkevinzheng
test: Fixed unsupported resource type in system test (#904)
4a65afc
parthea pushed a commit that referenced this pull request Nov 26, 2025
@arithmetic1728
fix: use 'int.to_bytes' and 'int.from_bytes' for py3 (#904)
f041735
parthea pushed a commit that referenced this pull request Nov 26, 2025
@release-please
chore: release 2.3.3 (#903)
c4fc33a 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.3.3](https://www.github.com/googleapis/google-auth-library-python/compare/v2.3.2...v2.3.3) (2021-11-01)


### Bug Fixes

* add fetch_id_token_credentials ([#866](https://www.github.com/googleapis/google-auth-library-python/issues/866)) ([8f1e9cf](https://www.github.com/googleapis/google-auth-library-python/commit/8f1e9cfd56dbaae0dff64499e1d0cf55abc5b97e))
* fix error in sign_bytes ([#905](https://www.github.com/googleapis/google-auth-library-python/issues/905)) ([ef31284](https://www.github.com/googleapis/google-auth-library-python/commit/ef3128474431b07d1d519209ea61622bc245ce91))
* use 'int.to_bytes' and 'int.from_bytes' for py3 ([#904](https://www.github.com/googleapis/google-auth-library-python/issues/904)) ([bd0ccc5](https://www.github.com/googleapis/google-auth-library-python/commit/bd0ccc5fe77d55f7a19f5278d6b60587c393ee3c))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Transactions are commited in CommitRequest.NON_TRANSACTIONAL mode

4 participants

@tseaver @dhermes @coveralls @googlebot