Add regex-based matching for left nav, include GAPIC Pub/Sub code#1187
Merged
Conversation
Use new 'pattern' regexp for left nav active state.
Use new 'pattern' regexp for left nav active state.
Use new 'pattern' regexp for left nav active state.
Use new 'pattern' regexp for left nav active state.
Use new 'pattern' regexp for left nav active state.
Remove 'matchServiceTitle', replace with 'patterns' in toc.json.
googlebot
added
the
cla: yes
Contributor
|
This LGTM. Let me know when you want it merged. |
swcloud
approved these changes
Jan 13, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides the following gh-pages docs changes:
Replaces
matchServiceTitleinmanifest.jsonwithpatternsintoc.json. This supports multi-word service titles (e.g., 'Natural Language') when the name in the package path is different (e.g.,google/cloud/language).Fixes the broken link to Core in the left nav
Adds GAPIC Pub/Sub code to the docs.
[fixes #1184, fixes #1142, closes #1074]