feat: Added public preview support for full-text search and geo search in Pipelines.#2346
Open
MarkDuckworth wants to merge 17 commits intomainfrom
Open
feat: Added public preview support for full-text search and geo search in Pipelines.#2346MarkDuckworth wants to merge 17 commits intomainfrom
MarkDuckworth wants to merge 17 commits intomainfrom
Conversation
product-auto-label
bot
added
size: xl
MarkDuckworth
commented
Mar 23, 2026
google-cloud-firestore/src/main/java/com/google/cloud/firestore/pipeline/stages/Search.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/google/cloud/firestore/pipeline/expressions/BooleanFunctionExpression.java
Show resolved
Hide resolved
...estore/src/main/java/com/google/cloud/firestore/pipeline/expressions/FunctionExpression.java
Show resolved
Hide resolved
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITPipelineSearchTest.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITPipelineSearchTest.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITPipelineSearchTest.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITPipelineSearchTest.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITPipelineSearchTest.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITPipelineSearchTest.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITPipelineSearchTest.java
Outdated
Show resolved
Hide resolved
…e this is untested for general cosumption
…estore into markduckworth/search
MarkDuckworth
changed the title
MarkDuckworth
commented
Apr 2, 2026
| * @param rquery Define the search query using the search domain-specific language (DSL). | ||
| * @return A new {@link Expression} representing the snippet operation. | ||
| */ | ||
| @BetaApi |
Contributor
Author
There was a problem hiding this comment.
I need to make this internal because it will not be supported at launch
cherylEnkidu
approved these changes
Apr 2, 2026
| public static final QueryEnhancement REQUIRED = new QueryEnhancement("required"); | ||
|
|
||
| /** Search will use the un-enhanced, user provided query. */ | ||
| public static final QueryEnhancement DISABLED = new QueryEnhancement("disabled"); |
Contributor
There was a problem hiding this comment.
can you let me know what is the reason for not using standard enum like this:
public enum QueryEnhancement {
PREFERRED("preferred"),
REQUIRED("required"),
DISABLED("disabled");
}
I checked the other place like ReplaceWith, and looks like they use standard enum
| // Disable priming as it uses Watch/Listen | ||
| } | ||
|
|
||
| @Before |
Contributor
There was a problem hiding this comment.
Should we use @BeforeClass so that it only run once for the whole test suite?
| getFirestoreEdition().equals(FirestoreEdition.ENTERPRISE) | ||
| && "NIGHTLY".equalsIgnoreCase(getTargetBackend())); | ||
|
|
||
| restaurantsCollection = firestore.collection(COLLECTION_NAME); |
Contributor
There was a problem hiding this comment.
Android has the step which deletes data, should we do the same in Java?
https://cs.opensource.google/firebase-sdk/firebase-android-sdk/+/main:firebase-firestore/src/androidTest/java/com/google/firebase/firestore/PipelineSearchTest.kt;l=134?q=PipelineSearchTest.kt&ss=firebase-sdk%2Ffirebase-android-sdk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
search API - features not available at launch have been marked internal or commented out