Skip to content

samples: Jupyter Notebook "#Try-inserting-the-documents-into-the-vector-table" is incompatible with the actual code and fails #137

@odeke-em

Description

@odeke-em

While trying to get end-to-end samples working alright, I encountered the section "#Try-inserting-the-documents-into-the-vector-table" when fails when given

def netflix_from_gcs():
    return read_csv_from_gcs(
        "cloud-samples-data", "langchain/netflix_titles_compute_embeddings.csv"
    )

def intialize_embedding_service(vector_store, documents):
    docs_to_load = documents[:100]
    print("docs_to_load[0]", docs_to_load[0])
                
    # ! Uncomment the following line to load all 8,800+ documents to the
    # database vector table with calling the embedding service.
    # docs_to_load = documents
    ids = [str(uuid.uuid4()) for i in range(len(docs_to_load))]
    vector_store.add_documents(docs_to_load, ids, batch_size=500)

with

docs_to_load[0] ['show_id', 'type', 'title', 'director', 'cast', 'country', 'date_added', 'release_year', 'rating', 'duration', 'listed_in', 'description']
Traceback (most recent call last):
  File "/Users/emmanuelodeke/go/src/github.com/googleapis/langchain-google-spanner-python/samples/search_knn.py", line 170, in <module>
    main()
  File "/Users/emmanuelodeke/go/src/github.com/googleapis/langchain-google-spanner-python/samples/search_knn.py", line 80, in main
    run_kNN_vector_store()
  File "/Users/emmanuelodeke/go/src/github.com/googleapis/langchain-google-spanner-python/samples/search_knn.py", line 136, in run_kNN_vector_store
    intialize_embedding_service(vector_store, documents)
  File "/Users/emmanuelodeke/go/src/github.com/googleapis/langchain-google-spanner-python/samples/search_knn.py", line 91, in intialize_embedding_service
    vector_store.add_documents(docs_to_load, ids, batch_size=500)
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/langchain_google_spanner/vector_store.py", line 923, in add_documents
    texts = [doc.page_content for doc in documents]
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/langchain_google_spanner/vector_store.py", line 923, in <listcomp>
    texts = [doc.page_content for doc in documents]
AttributeError: 'list' object has no attribute 'page_content'

Metadata

Metadata

Labels

api: spannerIssues related to the googleapis/langchain-google-spanner-python API.samplesIssues that are directly related to samples.

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions