Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

feat: add support for scripting/routines#580

Merged
steffnay merged 17 commits into
googleapis:masterfrom
callmehiphop:routines
Jan 30, 2020
Merged

feat: add support for scripting/routines#580
steffnay merged 17 commits into
googleapis:masterfrom
callmehiphop:routines

Conversation

@callmehiphop
Copy link
Copy Markdown
Contributor

@callmehiphop callmehiphop commented Nov 19, 2019

Closes #578 🦕

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@callmehiphop callmehiphop added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 19, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2019
@callmehiphop callmehiphop requested review from a team, shollyman and tswast November 19, 2019 00:47
@callmehiphop
Copy link
Copy Markdown
Contributor Author

Usage can be viewed easily via system-tests

Comment thread src/dataset.ts Outdated
Comment thread src/dataset.ts Outdated
Comment thread src/routine.ts
Comment thread src/routine.ts Outdated
Comment thread system-test/bigquery.ts
Comment thread system-test/bigquery.ts Outdated
@steffnay steffnay added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 28, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 28, 2020
@googlebot
Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jan 28, 2020
@steffnay steffnay added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 29, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 29, 2020
@steffnay
Copy link
Copy Markdown
Contributor

@googlebot I consent

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 29, 2020
@steffnay steffnay marked this pull request as ready for review January 29, 2020 20:54
@callmehiphop
Copy link
Copy Markdown
Contributor Author

callmehiphop commented Jan 29, 2020 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BigQuery: implement Routines API support

6 participants