chore(docs): add an Error handling sample#466
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
Pull request for the following issue: |
Codecov Report
@@ Coverage Diff @@
## master #466 +/- ##
=======================================
Coverage 97.97% 97.97%
=======================================
Files 6 6
Lines 691 691
Branches 161 161
=======================================
Hits 677 677
Misses 2 2
Partials 12 12Continue to review full report at Codecov.
|
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
Looks good. So, did we delete this sample file at some point, and now we're bringing it back? |
|
How can we make sure this new sample will have a home on the docs site and not be axed again? |
|
Perhaps bring it up on the chat and ask Frank Natividad? |
|
cc @frankyn! |
|
Summoning my colleague @BenWhitehead, who is my point person for Datastore/Firestore related DevEx. |
|
I'll poke around in docsite and figure out how/where this was published before and circle back. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
bcoe
left a comment
There was a problem hiding this comment.
this is awesome, another sample is always appreciated.
|
|
||
| const query = datastore.createQuery(['Company']).start('badrequest'); | ||
|
|
||
| return datastore |
There was a problem hiding this comment.
we tend to use an async function called main these days, here's a sample from the guidelines document:
function main(arg1 = 'default_value_one', arg2 = 1234) {
// [START your_region_tag]
/**
* TODO(developer): Uncomment these variables before running the sample.
*/
// const arg1 = 'default_value_one';
// const arg2 = 1234;
// Imports the Google Cloud Some API library
const {SomeApiClient} = require('@google-cloud/some-api');
// Instantiates a client
const someApiClient = new SomeApiClient();
async function doSomething() {
...
}
doSomething();
// [END your_region_tag]
}
main(...process.argv.slice(2));
Fixes #83 (it's a good idea to open an issue first for discussion)