Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

feat: Managed Autoscaler#1965

Closed
alkatrivedi wants to merge 5 commits intogoogleapis:mainfrom
alkatrivedi:managed-autoscaler
Closed

feat: Managed Autoscaler#1965
alkatrivedi wants to merge 5 commits intogoogleapis:mainfrom
alkatrivedi:managed-autoscaler

Conversation

@alkatrivedi
Copy link
Copy Markdown
Contributor

This PR contains code changes for manages autoscaler.

@alkatrivedi alkatrivedi requested review from a team December 8, 2023 03:16
@conventional-commit-lint-gcf
Copy link
Copy Markdown

conventional-commit-lint-gcf bot commented Dec 8, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@snippet-bot
Copy link
Copy Markdown

snippet-bot bot commented Dec 8, 2023

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Dec 8, 2023
@alkatrivedi alkatrivedi changed the title feat: code changes for managed autoscaler feat: Managed Autoscaler Dec 8, 2023
@product-auto-label product-auto-label bot added size: l Pull request size is large. size: m Pull request size is medium. and removed size: m Pull request size is medium. size: l Pull request size is large. labels Dec 11, 2023
feat: code changes for managed autoscaler

code changes for managed autoscaler

add license

lint changes

remove comments

remove .vscode folder

modify timeout in monarch

fix mismatched region tag

change copyright year to 2023
@@ -0,0 +1,93 @@
/**
* Copyright 2023 Google LLC
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Copyright 2023 Google LLC
* Copyright 2024 Google LLC

displayName,
nodeCount: config.nodes,
processingUnits: config.processingUnits,
autoscalingConfig: config.autoscalingConfig,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to do changes for Update Instance to handle below use case
When autoscaling config is set then node and processing unit should not be passed

@surbhigarg92
Copy link
Copy Markdown
Contributor

Add integration test case for create and update instance. Refer Python and Java PR

@alkatrivedi
Copy link
Copy Markdown
Contributor Author

Closing this PR, as there is no more need of this sample. I will add the similar samples using admin client.

@alkatrivedi alkatrivedi closed this Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/nodejs-spanner API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants