This repository was archived by the owner on Mar 3, 2026. It is now read-only.
chore!: drop keepAcl parameter in file copy#1166
Merged
Merged
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1166 +/- ##
==========================================
- Coverage 99.18% 99.17% -0.01%
==========================================
Files 12 12
Lines 11474 11454 -20
Branches 597 527 -70
==========================================
- Hits 11380 11360 -20
Misses 94 94
Continue to review full report at Codecov.
|
stephenplusplus
approved these changes
Apr 28, 2020
laljikanjareeya
approved these changes
May 7, 2020
Merged
BYK
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Jan 4, 2021
This is to upgrade the vulnerable `date-and-time` dependency. The latest version has the following breaking changes which are all okay: - automatically detect contentType if not provided (googleapis/nodejs-storage#1190) - drop keepAcl parameter in file copy (googleapis/nodejs-storage#1166) - drop support for node.js 8.x - allow leading slashes in file name (googleapis/nodejs-storage#820) - upgrade engines field to >=8.10.0 (googleapis/nodejs-storage#688)
BYK
added a commit
to getsentry/craft
that referenced
this pull request
Jan 5, 2021
This is to upgrade the vulnerable `axios` dependency. The latest version has the following breaking changes which are all okay: - automatically detect contentType if not provided (googleapis/nodejs-storage#1190) - drop keepAcl parameter in file copy (googleapis/nodejs-storage#1166) - drop support for node.js 8.x - allow leading slashes in file name (googleapis/nodejs-storage#820) - upgrade engines field to >=8.10.0 (googleapis/nodejs-storage#688)
BYK
added a commit
to getsentry/craft
that referenced
this pull request
Jan 5, 2021
This is to upgrade the vulnerable `axios` dependency. The latest version has the following breaking changes which are all okay: - automatically detect contentType if not provided (googleapis/nodejs-storage#1190) - drop keepAcl parameter in file copy (googleapis/nodejs-storage#1166) - drop support for node.js 8.x - allow leading slashes in file name (googleapis/nodejs-storage#820) - upgrade engines field to >=8.10.0 (googleapis/nodejs-storage#688)
BYK
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Jan 11, 2021
This is to upgrade the vulnerable `date-and-time` dependency. The latest version has the following breaking changes which are all okay: - automatically detect contentType if not provided (googleapis/nodejs-storage#1190) - drop keepAcl parameter in file copy (googleapis/nodejs-storage#1166) - drop support for node.js 8.x - allow leading slashes in file name (googleapis/nodejs-storage#820) - upgrade engines field to >=8.10.0 (googleapis/nodejs-storage#688)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.