Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

feat: add support for useAuthWithCustomEndpoint option#1645

Merged
ddelgrosso1 merged 2 commits into
googleapis:mainfrom
ddelgrosso1:ddelgrosso/custom-endpoint-auth
Oct 7, 2021
Merged

feat: add support for useAuthWithCustomEndpoint option#1645
ddelgrosso1 merged 2 commits into
googleapis:mainfrom
ddelgrosso1:ddelgrosso/custom-endpoint-auth

Conversation

@ddelgrosso1
Copy link
Copy Markdown
Contributor

@ddelgrosso1 ddelgrosso1 commented Oct 6, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1555 🦕

@ddelgrosso1 ddelgrosso1 requested review from a team October 6, 2021 21:49
@product-auto-label product-auto-label Bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Oct 6, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 6, 2021
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 6, 2021
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 6, 2021
@shaffeeullah
Copy link
Copy Markdown
Contributor

shaffeeullah commented Oct 6, 2021

this needs to be added to StorageOptions and also documented, right? we also need a test for it. also this should be feat and not fix i think?

shaffeeullah
shaffeeullah reviewed Oct 6, 2021
View reviewed changes
Comment thread package.json Outdated
"precompile": "gts clean"
},
"dependencies": {
"@google-cloud/common": "^3.7.0",
Copy link
Copy Markdown
Contributor

@shaffeeullah shaffeeullah Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merged this change separately here #1644

Copy link
Copy Markdown
Contributor Author

@ddelgrosso1 ddelgrosso1 Oct 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ddelgrosso1
Copy link
Copy Markdown
Contributor Author

ddelgrosso1 commented Oct 7, 2021

@shaffeeullah we do not need to add it to StorageOptions, StorageOptions extends ServiceOptions from common and I added the field there (trying to keep the changes as isolated to that lib as possible). I will add some documentation on it if I can figure out how we have been doing that in the past. I will also add a test to the constructor to make sure it is passed.

@ddelgrosso1 ddelgrosso1 force-pushed the ddelgrosso/custom-endpoint-auth branch from 275d4db to e1d6637 Compare October 7, 2021 14:32
@shaffeeullah shaffeeullah self-requested a review October 7, 2021 14:35
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 7, 2021
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 7, 2021
@ddelgrosso1 ddelgrosso1 force-pushed the ddelgrosso/custom-endpoint-auth branch from e1d6637 to 0d7f544 Compare October 7, 2021 14:42
@ddelgrosso1 ddelgrosso1 changed the title fix: add support for useAuthWithCustomEndpoint option feature: add support for useAuthWithCustomEndpoint option Oct 7, 2021
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 7, 2021
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 7, 2021
@ddelgrosso1 ddelgrosso1 changed the title feature: add support for useAuthWithCustomEndpoint option feat: add support for useAuthWithCustomEndpoint option Oct 7, 2021
@ddelgrosso1 ddelgrosso1 force-pushed the ddelgrosso/custom-endpoint-auth branch from 0d7f544 to a616819 Compare October 7, 2021 17:15
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 7, 2021
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 7, 2021
@ddelgrosso1 ddelgrosso1 added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Oct 7, 2021
@ddelgrosso1 ddelgrosso1 force-pushed the ddelgrosso/custom-endpoint-auth branch from a616819 to d843d51 Compare October 7, 2021 19:43
@ddelgrosso1 ddelgrosso1 added owlbot:run Add this label to trigger the Owlbot post processor. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 7, 2021
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 7, 2021
@ddelgrosso1 ddelgrosso1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 7, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 7, 2021
@ddelgrosso1 ddelgrosso1 merged commit d11d6b4 into googleapis:main Oct 7, 2021
@ddelgrosso1 ddelgrosso1 deleted the ddelgrosso/custom-endpoint-auth branch October 7, 2021 20:40
gcf-merge-on-green Bot pushed a commit that referenced this pull request Oct 7, 2021
@release-please
chore: release 5.15.0 (#1647)
23cb7d3 
🤖 I have created a release \*beep\* \*boop\*
---
## [5.15.0](https://www.github.com/googleapis/nodejs-storage/compare/v5.14.7...v5.15.0) (2021-10-07)


### Features

* add support for useAuthWithCustomEndpoint option ([#1645](https://www.github.com/googleapis/nodejs-storage/issues/1645)) ([d11d6b4](https://www.github.com/googleapis/nodejs-storage/commit/d11d6b4b2678cb240928e2dfe20f983d2ae896f6))


### Bug Fixes

* update common dep ([#1644](https://www.github.com/googleapis/nodejs-storage/issues/1644)) ([793467f](https://www.github.com/googleapis/nodejs-storage/commit/793467f25abf46eb7ba5e6cd1b80f735faa035dc))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@shaffeeullah shaffeeullah shaffeeullah approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/nodejs-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

3 participants

@ddelgrosso1 @shaffeeullah @yoshi-kokoro