Skip to content

chore: fix cs check, fix git-attributes, removed unused entrypoint.sh, fix cs#424

Merged
bshaffer merged 5 commits intomainfrom
fix-gitattributes
Apr 26, 2022
Merged

chore: fix cs check, fix git-attributes, removed unused entrypoint.sh, fix cs#424
bshaffer merged 5 commits intomainfrom
fix-gitattributes

Conversation

@bshaffer
Copy link
Copy Markdown
Collaborator

No description provided.

@bshaffer bshaffer changed the title chore: fix git-attributes chore: fix git-attributes, removed unused entrypoint.sh Apr 23, 2022
@bshaffer bshaffer changed the title chore: fix git-attributes, removed unused entrypoint.sh chore: fix cs check, fix git-attributes, removed unused entrypoint.sh, fix cs Apr 23, 2022
Comment thread src/JWT.php
throw new UnexpectedValueException('Invalid claims encoding');
}
if (is_array($payload)) {
if (\is_array($payload)) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the recommended syntax by the CS fixer?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://cs.symfony.com/doc/rules/function_notation/native_function_invocation.html

We get a performance bump by prefixing certain functions with a backslash

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh Sweet!

Copy link
Copy Markdown

@saranshdhingra saranshdhingra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bshaffer bshaffer merged commit 6a6025b into main Apr 26, 2022
@bshaffer bshaffer deleted the fix-gitattributes branch April 26, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants