-
Notifications
You must be signed in to change notification settings - Fork 324
feat: add custom cell magic parser #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
c5e63c6
chore: Move cell magic code into its own directory
plamut 199974f
Add custom argument parser for cell magic
plamut d3525d4
Add AST node visitor
plamut 5690b81
Use a custom parser for cell magic arguments
plamut 976567c
Improve cell magic parser test coverage
plamut f57c6cd
Generalize valid option values
plamut c7e4420
Fix recognizing --params option in state 3
plamut 90c504e
Fix typo in comment
plamut 3b94a55
Merge branch 'master' into fix-cellmagic-parser
plamut 5249c6a
Cover missing parser code path with a test
plamut 83218a2
Merge branch 'master' into fix-cellmagic-parser
plamut 2c74ec8
Preserve the cell magic context's import path
plamut 19af056
Clarify lexer states
plamut 4cbf7f2
Replace re.scanner with finditer()
plamut 64f19b5
Fix typo in docstring
plamut 5d10d36
Simplify string literal in a single line
plamut 46d1def
Explain the visitors module.
plamut ed01a66
Merge branch 'master' into fix-cellmagic-parser
plamut d9dd3e0
Pass pos as a positional arg to finditer()
plamut 415c608
Resolve coverage complaint about a code path
plamut File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Explain the visitors module.
- Loading branch information
commit 46d1defc2da106aa83d5d587e239a5ded86466c1
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.