-
Notifications
You must be signed in to change notification settings - Fork 45
feat: implement query profiling #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
7f46c52
added basics for query profiling
daniel-sanche e66c57f
changes dataclass ordering
daniel-sanche 1f1e8e1
refactored
daniel-sanche 1af61d1
added exceptions
daniel-sanche ac11cd2
refactoring of dataclasses
daniel-sanche 730411b
outlines of unit tests
daniel-sanche 5823dbc
got system tests passing
daniel-sanche aa9f334
implemented some unit tests
daniel-sanche 5cdba98
got query tests passing
daniel-sanche 0f971c6
added profiling to aggregation query
daniel-sanche 387b01b
added kwargs to client.aggregation_query
daniel-sanche ddec61d
partially implemented aggregation query system tests
daniel-sanche cca1f00
removed outdated test
daniel-sanche cd97827
added last agg system test
daniel-sanche 96d6d52
fixed lint
daniel-sanche 3cf9d8a
fixed system tests
daniel-sanche 4c24b84
added in transaction tests
daniel-sanche 73ad241
fixed system tests
daniel-sanche 686e722
moved datacalsses into new file
daniel-sanche 4ebf0de
improved docstrings
daniel-sanche f2de107
aggregation uses nested query explain options
daniel-sanche 0abea2f
fixed parsing bug
daniel-sanche d4f4475
added samples
daniel-sanche fc6187e
moved query_profile model tests to new file
daniel-sanche eced67d
better handle empty debug stats
daniel-sanche 730e7cb
fixed test
daniel-sanche ab8d7a2
fixed lint
daniel-sanche e02b20d
fixed samples lint
daniel-sanche 02afe92
added missing test cases
daniel-sanche 5dcf063
added back removed test
daniel-sanche 5cf1f88
fixed lint
daniel-sanche 51ffa9e
added test
daniel-sanche c6df706
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 7d2e597
more lenient in system test
daniel-sanche e9e72b6
removed import
daniel-sanche 083e604
added debug stats checks
daniel-sanche 58c3c57
Apply suggestions from code review
daniel-sanche c77f299
Merge branch 'main' into query_profiling
daniel-sanche 7d802e3
Merge branch 'main' into query_profiling
daniel-sanche 5a644ab
Merge branch 'main' into query_profiling
daniel-sanche b2a9a77
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] e67ca72
fixed new_query calculation
daniel-sanche 4319ac7
added comment
daniel-sanche 175c76a
Merge branch 'main' into query_profiling
daniel-sanche c5d8a76
fixed offset calculation
daniel-sanche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fixed new_query calculation
- Loading branch information
commit e67ca728a982b15b6d2bc0f18fe9c27f07014471
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
request.copy()here also for testability?copy()is only a shallow copy for dict, do we need to make a deep copy here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, IIRC it's just for testability.
We want to be able to make assertions about the arguments passed in to each call, which doesn't work if the same request instance is used for each request