Skip to content
This repository was archived by the owner on Mar 2, 2026. It is now read-only.

feat: use 'update_transforms' #219

Merged
gcf-merge-on-green merged 7 commits into from
Oct 10, 2020
Merged

feat: use 'update_transforms' #219

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
51295fd
feat: add 'update_transforms' to '_helpers.pbs_for_create'
tseaver Oct 7, 2020
c2622ae
feat: add 'update_transforms' to '_helpers.pbs_for_set_no_merge'
tseaver Oct 7, 2020
0c2f950
feat: add 'update_transforms' to '_helpers.pbs_for_set_with_merge'
tseaver Oct 7, 2020
7b8d9b0
feat: add 'update_transforms' to '_helpers.pbs_for_update'
tseaver Oct 7, 2020
044ef52
chore: lint
tseaver Oct 7, 2020
744f65c
tests: copy in current conftest JSON files
tseaver Oct 7, 2020
473aa09
Merge branch 'master' into 217-support-update_transforms
tseaver Oct 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: lint
  • Loading branch information
@tseaver
tseaver committed Oct 7, 2020
commit 044ef52926272122e717cc6e1293444e458f2902
7 changes: 0 additions & 7 deletions tests/unit/v1/test__helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1271,10 +1271,6 @@ def test_get_update_pb_wo_exists_precondition(self):
self.assertFalse(update_pb._pb.HasField("current_document"))

def test_get_field_transform_pbs_miss(self):
from google.cloud.firestore_v1.types import write
from google.cloud.firestore_v1.transforms import SERVER_TIMESTAMP
from google.cloud.firestore_v1._helpers import REQUEST_TIME_ENUM

document_data = {"a": 1}
inst = self._make_one(document_data)
document_path = (
Expand Down Expand Up @@ -1563,7 +1559,6 @@ def _make_write_w_document(document_path, **data):

@staticmethod
def _add_field_transforms(update_pb, fields):
from google.cloud.firestore_v1.types import write
from google.cloud.firestore_v1 import DocumentTransform

server_val = DocumentTransform.FieldTransform.ServerValue
Expand Down Expand Up @@ -1632,7 +1627,6 @@ def _make_write_w_document(document_path, **data):

@staticmethod
def _add_field_transforms(update_pb, fields):
from google.cloud.firestore_v1.types import write
from google.cloud.firestore_v1 import DocumentTransform

server_val = DocumentTransform.FieldTransform.ServerValue
Expand Down Expand Up @@ -1925,7 +1919,6 @@ def _make_write_w_document(document_path, **data):

@staticmethod
def _add_field_transforms(update_pb, fields):
from google.cloud.firestore_v1.types import write
from google.cloud.firestore_v1 import DocumentTransform

server_val = DocumentTransform.FieldTransform.ServerValue
Expand Down