Skip to content

chore: internal change #2131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Mar 9, 2026
Merged

chore: internal change #2131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions google/genai/_interactions/types/dynamic_agent_config_param.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,12 @@

from __future__ import annotations

from typing import Dict, Union
from typing_extensions import Literal, Required, TypeAlias, TypedDict
from typing_extensions import Literal, Required, TypedDict

__all__ = ["DynamicAgentConfigParam"]


class DynamicAgentConfigParamTyped(TypedDict, total=False):
class DynamicAgentConfigParam(TypedDict, total=False, extra_items=object): # type: ignore[call-arg]

@acoroleu-tempus acoroleu-tempus Mar 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wanlin31 the extra_items breaks in python 3.11.

The project claims to support Python 3.10, 3.11, 3.12, 3.13, and 3.14 — but the extra_items syntax in this commit breaks anything below 3.13.

@wanlin31 wanlin31 Mar 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the inconvenience, working on investigate it.

@RobertCraigie RobertCraigie Mar 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @acoroleu-tempus, I think you ran into an error because our minimum required typing-extensions version is too low, we're going to bump it. In the meantime if you update it to 4.14 or later then you should be good!

"""Configuration for dynamic agents."""

type: Required[Literal["dynamic"]]


DynamicAgentConfigParam: TypeAlias = Union[DynamicAgentConfigParamTyped, Dict[str, object]]