Skip to content

feat: Add parameter on Marker to control info window visibility state - #33

Closed
scavazzini wants to merge 2 commits into
googlemaps:mainfrom
scavazzini:scavazzini/feat/marker_visibility_state
Closed

feat: Add parameter on Marker to control info window visibility state#33
scavazzini wants to merge 2 commits into
googlemaps:mainfrom
scavazzini:scavazzini/feat/marker_visibility_state

Conversation

@scavazzini

Copy link
Copy Markdown

This pull request adds a new parameter on Marker composables to control the info window visibility state.


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #16 🦕

@arriolac

Copy link
Copy Markdown
Contributor

Unfortunately the approach of having a state object for the info window's visibility will not work as only one info window can be visible at a time. An info window's visibility is completely managed by the SDK and so I think the best approach is to expose a show/hide method on a MarkerState. I should have a PR that builds on top of this shortly.

@scavazzini scavazzini closed this Mar 20, 2022
@scavazzini
scavazzini deleted the scavazzini/feat/marker_visibility_state branch March 20, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Displaying info window as soon as a marker is added

2 participants