feat: Add parameter on Marker to control info window visibility state - #33
Closed
scavazzini wants to merge 2 commits into
Closed
feat: Add parameter on Marker to control info window visibility state#33scavazzini wants to merge 2 commits into
scavazzini wants to merge 2 commits into
Conversation
Contributor
|
Unfortunately the approach of having a state object for the info window's visibility will not work as only one info window can be visible at a time. An info window's visibility is completely managed by the SDK and so I think the best approach is to expose a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new parameter on
Markercomposables to control the info window visibility state.Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #16 🦕