chore: Improve Scalebar example in readme - #343
Merged
wangela merged 2 commits intoJul 28, 2023
Conversation
Make readme documentation for Scalebar composable clearer.
DarrylBayliss
changed the title
wangela
approved these changes
Jul 28, 2023
Member
|
Thank you for this improvement to the README! ack that instrumentation tests fail on forks; merging this since it's only a README edit. |
Contributor
|
🎉 This PR is included in version 2.13.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a small improvement to the readme documentation, showing a fuller example on how to use
ScaleBarandDisappearingScaleBar.I made the mistake of using these composables inside
GoogleMap, causing the crash encountered in #335. The idea is this change makes it less likely others would do the same.Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #335