fix: improve MarkerState API - #515
Merged
Merged
Conversation
Contributor
Author
|
To be clear: replacing The MarkerDragEventsActivity example doubles as a proof of concept demonstrating how to recreate |
Contributor
Author
|
@wangela can I get a review for this PR, please? I'd really like to use these improvements. Thanks. |
This is a non-breaking change following suggestions from @arriolac for addressing googlemaps#149: googlemaps#150 (comment) This PR does not add an `onDrag` callback parameter to `Marker()`, which would be a somewhat breaking change; this functionality is not strictly necessary and I see alternatives that may be preferable. Summary of changes: 1. Deprecate MarkerState.dragState and DragState enum. These were carried over from GoogleMap SDK; they are events that were mischaracterized as states. 2. Replace with MarkerState.isDragging boolean. 3. Clarify KDoc in several places. 4. Add several examples providing patterns for common use cases. 5. Organize Marker-related examples into their own folder. Fixes googlemaps#149
…States from a changing model list of marker positions by collecting results from key() composable Rename marker examples folder to markerexamples for clarity
bubenheimer
force-pushed
the
improve_markerstate
branch
from
May 27, 2024 13:49
c8d1f88 to
04342cf
Compare
dkhawk
approved these changes
Jun 6, 2024
dkhawk
approved these changes
Jun 6, 2024
googlemaps-bot
pushed a commit
that referenced
this pull request
Jun 6, 2024
## [5.0.3](v5.0.2...v5.0.3) (2024-06-06) ### Bug Fixes * improve MarkerState API ([#515](#515)) ([3b40b92](3b40b92)), closes [#149](#149) [/github.com//pull/150#discussion_r1016963262](https://github.com//github.com/googlemaps/android-maps-compose/pull/150/issues/discussion_r1016963262) [#149](#149)
Contributor
|
🎉 This PR is included in version 5.0.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a non-breaking change following suggestions from @arriolac for addressing #149: #150 (comment)
This PR does not add an
onDragcallback parameter toMarker(), which would be a somewhat breaking change; this functionality is not strictly necessary and I see alternatives that may be preferable.Summary of changes:
Fixes #149