Add new groups confirmation page#2775
Open
thomasiles wants to merge 6 commits into
Open
Conversation
Add a new input object for the confirm action on the new groups page.
When a user creates a new group, they are asked to confirm that they want to create the group. This commit adds the view for this page.
Add a new route to show the new confirmation page when creating new groups.
Add form handler for the new group confirmation page.
Change the create link on the groups index page to point to the confirm page. We update the tests which rely on this.
Change the content, title, and back link for the new group page to match the new designs.
4e7f1df to
1c78a53
Compare
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2775.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new page with content to slow when creating a new group
Trello card: https://trello.com/c/KETW4If8/3099-add-a-new-page-after-a-user-clicks-create-a-group
This PR adds a new page between clicking "Create group" and giving the group a name. It also updates the content on the new groups page.
The new page is to confirm the user wants to create a group and give them more information about what a group is. The content is different for organisations which have an admin.
The existing new group page can still be accessed directly through URL. The create group button link has been changed to this new page.
Note
I made up some content for the validation message the user sees when they don't check yes or no and submit the page.
Without org admins
With org admins
Without selecting yes/no
The updated new group page
Things to consider when reviewing