Skip to content

Change 'end of form' to 'end of the form'#2777

Merged
hannahkc merged 6 commits into
mainfrom
hannahkc-end-of-form
May 14, 2026
Merged

Change 'end of form' to 'end of the form'#2777
hannahkc merged 6 commits into
mainfrom
hannahkc-end-of-form

Conversation

@hannahkc
Copy link
Copy Markdown
Contributor

@hannahkc hannahkc commented May 14, 2026

What problem does this pull request solve?

This changes:

  • 'end of form' to 'the end of the form' where it's part of a sentence
  • 'End of form' to 'End of the form' where it's a fragment

This is for style, consistency and readability.

Trello card:https://trello.com/c/JciJ9SsL/3549-card-in-progress-correct-end-of-form-to-end-of-the-form-or-the-end-of-the-form-as-relevant

Things to consider when reviewing

  • I can't run this locally so I hope it all looks ok! I will be checking in the review apps!
  • I hope I have caught all the tests etc...
  • I haven't been able to squash these commits as it turns out I can't have github desktop on my new computer. Sorry about that! If someone can easily do that for me (I think that's possible?), that would be super!
  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@github-actions
Copy link
Copy Markdown

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2777.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@hannahkc hannahkc added this pull request to the merge queue May 14, 2026
Merged via the queue into main with commit 1c1a4b2 May 14, 2026
5 checks passed
@hannahkc hannahkc deleted the hannahkc-end-of-form branch May 14, 2026 15:23
stephencdaly added a commit to govuk-forms/forms-e2e-tests that referenced this pull request May 14, 2026
Allow the e2e tests to pass with either the old content or the new
content, to alow govuk-forms/forms-admin#2777
to be deployed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants